Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344244 - illegal API use in org.eclipse.modisco.infra.discovery.ui.internal.celleditors.composite.TargetURIComposite
Summary: illegal API use in org.eclipse.modisco.infra.discovery.ui.internal.celleditor...
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Infrastructure (show other bugs)
Version: 0.9.0   Edit
Hardware: All All
: P1 normal (vote)
Target Milestone: 0.9.1 RC2   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-29 04:51 EDT by Nicolas Bros CLA
Modified: 2012-05-29 08:29 EDT (History)
4 users (show)

See Also:
Kenn.Hussey: pmc_approved+

Attachments
patch (4.59 KB, patch)
2011-06-07 11:11 EDT, Nicolas Bros CLA 		gdupe: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2011-04-29 04:51:26 EDT 
org.eclipse.modisco.infra.discovery.ui.internal.celleditors.composite.TargetURIComposite contains an anonymous class that extends org.eclipse.ui.dialogs.SaveAsDialog, which is marked @noextend
Comment 1 Nicolas Bros CLA 2011-06-07 11:11:24 EDT 
Created attachment 197507 [details]
patch

This patch replaces the use of the SaveAsDialog class by WorkspaceResourceDialog from EMF Common UI, so as to avoid having to subclass SaveAsDialog.
Comment 2 Gregoire Dupe CLA 2011-08-22 08:05:28 EDT 
Hello Kenn,

Here is a patch fixing the illegal use of org.eclipse.ui.dialogs.SaveAsDialog by a MoDisco 0.9 component. 

Cf. http://download.eclipse.org/modeling/mdt/modisco/downloads/drops/0.9.0/R201106080421/api_report/html/org.eclipse.ui.ide%20%283.7.0%29/org.eclipse.ui.dialogs.SaveAsDialog.html

Do you agree to apply this patch in the service release?

Regards,
Gregoire
Comment 3 Nicolas Bros CLA 2011-08-22 10:37:20 EDT 
Committed on trunk (revision 4533) and branch 0_9 (revision 4534).
Comment 4 Hugo Bruneliere CLA 2012-05-29 08:29:48 EDT 
Already solved.