Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344242 - Extract Function: Improvements to the dialog
Summary: Extract Function: Improvements to the dialog
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-refactoring (show other bugs)
Version: 8.0   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: 8.1.0   Edit
Assignee: Sergey Prigogin CLA
QA Contact: Sergey Prigogin CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-29 04:48 EDT by Markus Schorn CLA
Modified: 2012-02-24 20:58 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Schorn CLA 2011-04-29 04:48:03 EDT
When using the 'Extract Function' refactoring a dialog is shown. I suggest the following improvements:

(1) There is a group named 'Return value:', however it primarily deals with the
    parameters.

(2) The option 'No return value (void)' is confusing: When I do not check this
    option and do not select any of the radio buttons in the 'return' column,
    I will still get no return value.
    It looks like the only purpose of the option is to allow for deselecting
    the radio button in the return column, once it has been selected.
    --> I suggest to remove this option and let the user deselect a radio button
        by clicking on it again. 

(3) For c++ it be nice to have the option to use a pointer type rather than a
    reference type for arguments passed by-reference.

(4) It'd be nice to show a preview of the function declaration.
Comment 1 Martin Oberhuber CLA 2011-07-21 16:41:13 EDT
CQ:WIND00252467
Comment 2 Sergey Prigogin CLA 2012-02-24 20:58:12 EST
Take a look at the new dialog and let me know how you like it.