Community
Participate
Working Groups
Created from: TYCHO-426: tycho-versions-plugin does not preserve MANIFEST.MF EOL https://issues.sonatype.org/browse/TYCHO-426 Original Description: While releasing m2e version, I've noticed that tycho-versions-plugin changed EOL from windows to unix for all bundle manifests it touched. Original Comments: == bstrasser == [1295802113000] Fixed in my fork: https://github.com/b8/sonatype-tycho/commit/95131b3b0e35214490049c5ac20a2bd917510cf6
I'll look at the contribution once the Tycho sources are in parallel IP at Eclipse.
Created attachment 194889 [details] Bugfix with tests https://github.com/b8/sonatype-tycho/commit/4e8e041f56abf7ee6623fef9a0fe93aa0a4807a8
I'm don't have much experience with the tycho-versions-plugin, but your changes look good to me (and I particularly like the test coverage), so I am willing to integrate them. The only open point are the copyright headers: * Who owns the intellectual property of your changes? This is typically your employer. What is the name of your employer? * Do you want to be listed as contributor with name, e.g. "Beat Strasser (<company>) - preserve EOL in manifests", or only have your employer listed under contributions? * Did you write the ManifestAttributeTest yourself, or did you copy it from somewhere? The current copyright header appears to be copied in error.
Created attachment 197915 [details] Bugfix and tests incl correct copyright headers I've updated my patch with new copyright headers. I hope it's ok now. I'd liked to be listed with my name and my employer "Inventage AG". The ManifestAttributeTest isn't copied from anywhere (except the obsolete copyright info...), I've fixed this. Thanks for applying the patch!
Beat, thank you for the updated patch. I have created CQ 5285 for it because it exceeds 250 lines. Let's hope the CQ will go through quickly.
Beat, the IP team wants you to answer the following questions: 1) Did you author 100% of the contributed code? 2) Do you have the right to donate content to Eclipse? 3) Do you contribute the content under the EPL? They also need your employer to confirm that you have the permission to contribute this patch under the EPL. The confirmation can be sent via e-mail. (I'll give you the contact in private.)
(In reply to comment #6) > Beat, the IP team wants you to answer the following questions: > 1) Did you author 100% of the contributed code? Yes, the contributed code has been created by refactoring the existing code and without copying or using work from anyone else. > 2) Do you have the right to donate content to Eclipse? Yes. My employer permission will follow soon per mail. > 3) Do you contribute the content under the EPL? Yes, I do.
Comment on attachment 197915 [details] Bugfix and tests incl correct copyright headers CQ 5285 is approved - committing patch. Thank you Beat!
Fixed with 7dfcd7f.
