Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344203 - [client] cheap js content assist
Summary: [client] cheap js content assist
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: 0.4 M2   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 367232 367233 367252 367426
Blocks:
  Show dependency tree
 
Reported: 2011-04-28 16:39 EDT by Susan McCourt CLA
Modified: 2012-01-24 09:23 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2011-04-28 16:39:13 EDT 
Gosia mentioned on the Orion call today that the web tools js content assist support is enough to keep her in the Eclipse IDE and out of Orion.

In the past we've talked about developing a "killer" js content assist that was best of breed, but it seems for our June release we should at least look at what kind of cheap solution would be "good enough" for a web tools user to consider moving to Orion.

The content assist wouldn't necessarily have to be as good as web tools, but good enough so that other Orion features (like jslint) would make it compelling for an Eclipse user to move to Orion without feeling like they were giving up too much.
Comment 1 Susan McCourt CLA 2011-04-28 16:40:18 EDT 
Now that Mark has done work in bug 343774, maybe this is easier to hand off to someone for experimentation?

Marking 0.2M8 as this seems to be a self-hosting blocker, but note we don't have anyone assigned to it yet.
Comment 2 Mark Macdonald CLA 2011-04-28 17:08:18 EDT 
(In reply to comment #0)
We're already running JSLint, and it's smart enough to know what names are defined in a given scope. Maybe the content assist can take advantage of that?

If I could press Ctrl+Space and see the variables from my current function appear in the suggestion list, I'd consider that a big win.
Comment 3 John Arthorne CLA 2011-06-06 09:23:51 EDT 
We have only content assist for keywords, but I think this is all we will be able to do for 0.2.
Comment 4 Mark Macdonald CLA 2011-08-04 15:34:55 EDT 
Somewhat related:

There's an example plugin at [1] that uses the language js parser to provide identifier completion. However it is woefully unaware of scope rules, so it offers a lot of irrelevant suggestions.

But language js seems like a good starting point for doing something smarter.

[1] http://mamacdon.github.com/0.2/plugins/language/languagejsPlugin.html
Comment 5 Susan McCourt CLA 2011-10-27 13:12:27 EDT 
marking 0.4 for visibility, since this is mentioned as potential theme for 0.4 (but it is not assigned yet)
Comment 6 John Arthorne CLA 2011-12-20 13:02:24 EST 
I'm going to work on some incremental improvements here. The problem with using an existing parser is likely that they won't handle malformed scripts very well. When invoking content assist, the script is almost never well-formed. I'm going to start by picking off the low-hanging fruit and we can go from there.
Comment 7 John Arthorne CLA 2012-01-24 09:23:29 EST 
Marking this fixed based on the work in M2 (see blocker bugs). Further improvements can be captured in different bugs.