Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344182 - [Compatibility] USER bindings don't override SYSTEM bindings
Summary: [Compatibility] USER bindings don't override SYSTEM bindings
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.1 RC1   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-28 14:57 EDT by Paul Webster CLA
Modified: 2011-05-16 10:03 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2011-04-28 14:57:12 EDT 
Currently a user binding is treated like a conflict, when in 3.x the USER binding overrides the system binding.

If the user assigns F12 to About and does nothing else, in 3.x F12 will open the about dialog since it overrides the F12->Activate Editor binding.  In 4.1 it is judged a conflict.

See org.eclipse.e4.ui.keybinding.tests.BindingPersistenceTest.testAboutBindingIn3x()

PW
Comment 1 Dani Megert CLA 2011-04-29 01:41:35 EDT 
Is this only on Linux? Isn't this more severe than just 'normal'?
Comment 2 Paul Webster CLA 2011-04-29 09:47:40 EDT 
(In reply to comment #1)
> Is this only on Linux? Isn't this more severe than just 'normal'?

Arguably it's more consistent.  In 3.x the keys preference page reports those 2 bindings in conflict ... but then the system will pick the user one.

Now they match :-)

It's something that needs to be addressed before 4.1 ships, but I'm not convinced that providing the 3 states (a keybinding that works, a keybinding that works because of overrides, and a keybinding that doesn't work because of conflicts) is a good idea.

In 4.1 we will also be including the Key-Assist-To-Choose-Conflicts dialog.  That means it will open the key assist dialog and allow the user to choose.

PW
Comment 3 Paul Webster CLA 2011-05-13 14:35:54 EDT 
Fixed as part of bug 344181

PW
Comment 4 Dani Megert CLA 2011-05-16 10:03:40 EDT 
Verified in 4.1 build: I20110515-0800.