Community
Participate
Working Groups
The Nattable widget should provide a method selectRows. This method will allow to select a full line, corresponding to an EObject. It will be useful in order to use "Link with Editor" between the model browser and the Editor.
Created attachment 194277 [details] This patch adds the method selectRows to the widget API (1) I, Vincent Lorenzo, wrote 100% of the code I've provided. (2) This code contains no cryptography (3) I have the right to contribute the code to Eclipse. (4) I contribute the content under the EPL. The corresponding JUnit Test is coming soon.
Comment on attachment 194277 [details] This patch adds the method selectRows to the widget API Here is a patch smaller than 250 lines (117 lines), no CQ are then needed. I've committed this patch. Committed revision 600.
A unit test has to be written before to mark this bug as resolved. Regards, Gregoire Dupe
Created attachment 194589 [details] The test for the selectRows methods (1) I, Vincent Lorenzo, wrote 100% of the code I've provided. (2) This code contains no cryptography (3) I have the right to contribute the code to Eclipse. (4) I contribute the content under the EPL.
Created attachment 194591 [details] The test for the selectRows methods (1) I, Vincent Lorenzo, wrote 100% of the code I've provided. (2) This code contains no cryptography (3) I have the right to contribute the code to Eclipse. (4) I contribute the content under the EPL.
Created attachment 194592 [details] Change the behavior of getSelection() + Add a parameter to selectRows (1) I, Vincent Lorenzo, wrote 100% of the code I've provided. (2) This code contains no cryptography (3) I have the right to contribute the code to Eclipse. (4) I contribute the content under the EPL. In this new patch : getSelection returns the element represented by the line when the fully line is selected selectRows(List<EObject> objectsToSelect, boolean clearTheSelection). The second parameters is useful for the JUnit test : it allows to test the function getSelection when a line + a cell are selected.
Comment on attachment 194592 [details] Change the behavior of getSelection() + Add a parameter to selectRows Hello Vincent, Please, don't format the lines you haven’t modified. Otherwise, it’s ok for me. Regards, Gregoire Dupe
Created attachment 194905 [details] Change the behavior of getSelection() + Add a parameter to selectRows Hello Grégoire, I'm sorry for the format. This is the same same patch without the format action! (1) I, Vincent Lorenzo, wrote 100% of the code I've provided. (2) This code contains no cryptography (3) I have the right to contribute the code to Eclipse. (4) I contribute the content under the EPL. Regards, -- Vincent Lorenzo
Comment on attachment 194591 [details] The test for the selectRows methods Here is a patch smaller than 250 line (76 lines), no CQ is then needed. I've commited this patch. Committed revision 633.
Comment on attachment 194905 [details] Change the behavior of getSelection() + Add a parameter to selectRows Here is a patch smaller than 250 line (115 lines), no CQ is then needed. I've commited this patch. Committed revision 633.
This bug can be marked as fixed.
The committed patches may cause a regression: The unit test "org.eclipse.emf.facet.widgets.nattable.tests.NatTableHandlersTests.selectionTest " fails.
The test "selectionTest" has to be modified because the behavior of INatTableWidget.getSelection() has been changed by the patch (attachment 194905 [details]). I've committed a fix. (Committed revision 634.)
Hello, All unit tests succeed in the build https://hudson.eclipse.org/hudson/job/emffacet-nightly/299/. We can then mark this bug as resolved. Regards, Gregoire Dupe
This bug can be marked as closed.
