Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344101 - [implementation] out-of-sync handling: keeping Eclipse editor content should dirty the editor
Summary: [implementation] out-of-sync handling: keeping Eclipse editor content should ...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 3.8 M7   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 123598 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-04-28 06:06 EDT by Dani Megert CLA
Modified: 2012-04-30 04:54 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-04-28 06:06:23 EDT
When a file is out-of-sync we show a dialog where the user can choose whether to keep the current Eclipse editor content or replace it with the content from the file system. If the Eclipse editor content is kept then we don't dirty the editor and also don't change the file on the file system.

Problems:
1. When closing the editor we don't notify the user and the Eclipse content is 
   lost.
2. When reopening the file we tell the user again that the file is not in sync.

==> We should synchronize the file and then paste the Eclipse editor content into it so that it gets dirty.
Comment 1 Dani Megert CLA 2011-04-28 08:23:21 EDT
Like that since 1.0!
Comment 2 Dani Megert CLA 2011-04-28 08:58:22 EDT
*** Bug 123598 has been marked as a duplicate of this bug. ***
Comment 3 Dani Megert CLA 2012-04-03 08:35:05 EDT
I've fixed the data loss bug (1.) which is really what this bug is all about.  

Fixed in master: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=5719618e550ebc69298a1fbbf203d534a846a193
Comment 4 Dani Megert CLA 2012-04-30 04:54:21 EDT
Verified in I20120429-2000.