Community
Participate
Working Groups
The following code pieces will break compilation after toggle-refactoring: Case one: differing parameter names Header file: struct myClass { int fVal; myClass(int headername); }; Implementation file with different parameter name, implname instead of headername: myClass::myClass(int implname) : fVal(implname) {} Result in header file after toggling, parameter name of header file is not adjusted: struct myClass { int fVal; myClass(int headername) : fVal(implname) {} }; Case two: missing parameter name Header file, parameter name left off: struct myClass { int fVal; myClass(int); }; Implementation file with parameter name set to implname: myClass::myClass(int implname) : fVal(implname) {} Result in header file after toggling, missing name of parameter does not get set: struct myClass { int fVal; myClass(int) : fVal(implname) {} };
Fixed in HEAD > 20110428
*** cdt cvs genie on behalf of egraf *** Bug 344077: Toggle Function: different or missing function parameter names will break code <a href=https://bugs.eclipse.org/bugs/show_bug.cgi?id=344077>https://bugs.eclipse.org/bugs/show_bug.cgi?id=344077</a> [*] ToggleSimpleFunctionRefactoring.rts 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui.tests/resources/refactoring/ToggleSimpleFunctionRefactoring.rts?root=Tools_Project&r1=1.1&r2=1.2 [*] ToggleNodeHelper.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/togglefunction/ToggleNodeHelper.java?root=Tools_Project&r1=1.2&r2=1.3