Community
Participate
Working Groups
The new repository dialog for gerrit repositories should validate the url if it is a valid gerrit instance or not and could provide a hint. Just tested: http://egit.eclipse.org/ and wizard told me that "login failed" but the actual problem was the missing "/r" at the end of the url.
Agreed that the validation should be improved.
+1 that the valiation needs to be improved, see also bug 378897 (In reply to comment #0) > Just tested: http://egit.eclipse.org/ and wizard told me that "login failed" but > the actual problem was the missing "/r" at the end of the url. But in this case, I don't see how we could hint about the missing /r, because isn't that simply the Eclipse specific location? (I'm not sure, because Gerrit urls are so weird..) I think the proper thing to do here is to indicate simply that the URL does no point to a valid Gerrit repository, correct?
Here's an initial attempt at improving validation marginally: https://git.eclipse.org/r/#/c/10174/1
Benny, please review https://git.eclipse.org/r/#/c/10174/ Note that we've improved validation but we can't actually solve your original reported problem. :) That's because Gerrit only throws a GerritLoginException..we don't get any details as to why, except that there is actually a server there.
Merged: https://git.eclipse.org/r/#/c/10174/ I wasn't actually sure whether to resolve this as fixed or wontfix given comment 2, but we did at least make it better. :)
.
