Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344038 - [client] git log page is empty when I choose gitlog command from a subfolder or file
Summary: [client] git log page is empty when I choose gitlog command from a subfolder ...
Status: RESOLVED WORKSFORME
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-27 15:49 EDT by Susan McCourt CLA
Modified: 2011-08-30 10:20 EDT (History)
5 users (show)

See Also:


Attachments
console showing successful get when doing gitlog on file/A/?page=1 (144.15 KB, image/png)
2011-04-27 15:51 EDT, Susan McCourt CLA
no flags Details
no children from file/A/static/?page=1 (126.64 KB, image/png)
2011-04-27 15:53 EDT, Susan McCourt CLA
no flags Details
a zip file exported from Libing's server (68.67 KB, application/zip)
2011-05-02 14:17 EDT, libing wang CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2011-04-27 15:49:27 EDT
- fresh workspace
- linked to a subfolder of my git repo (folder org.eclipse.orion.client.core -> linked to c:\_git\orion\org.eclipse.orion.client\bundles\org.eclipse.orion.client.core)
- select "Git Log" from org.eclipse.orion.client.core
- success.
- select "Git Log" from the subfolder "static"
- empty log page.

The server reports no children.  (console screen snaps attached)
Comment 1 Susan McCourt CLA 2011-04-27 15:51:33 EDT
Created attachment 194204 [details]
console showing successful get when doing gitlog on file/A/?page=1
Comment 2 Susan McCourt CLA 2011-04-27 15:53:47 EDT
Created attachment 194205 [details]
no children from file/A/static/?page=1
Comment 3 Susan McCourt CLA 2011-04-27 17:42:10 EDT
marking M7 as this seems quite important.
Libing and Szymon told me this morning that it was working for them.
I started with a clean workspace to ensure that it wasn't something wrong on my end.  Let me know if you need me to debug...
Comment 4 Susan McCourt CLA 2011-04-27 18:12:04 EDT
I cloned a github repo and in that repo, git log works for individual files that have changed.

Is it possible that it only works if you cloned the repo from Orion?

There is still something fishy about the self-hosting scenario, where you link to a repo that you cloned from a non-jgit repo.  It smacks of a jgit bug somewhere to me.  Reminds me of that autocrlf problem from before...people who use jgit repos don't see a problem, but I see it all the time (because my repo was cloned by a different tool.)

Maybe the answer is "clone the repo with orion or jgit" for now, but I'd like to understand the problem.
Comment 5 Susan McCourt CLA 2011-04-27 18:56:32 EDT
I've just cloned the orion client repo from eclipse.org using Orion, and the git log works for the most part.  (There are some timeouts, opened bug 344056 for that).

So I believe that this bug is specific to git repositories that were not cloned by jgit.  I have no idea what the specific difference in the repo would be.  I'll be keeping my msysgit repo around if anyone wants to log into my Orion setup and see what's happening.
Comment 6 Susan McCourt CLA 2011-04-28 11:37:04 EDT
removing milestone since this is not a general problem and not present in the orion hub usage.
Comment 7 libing wang CLA 2011-05-02 14:17:33 EDT
Created attachment 194523 [details]
a zip file exported from Libing's server

Git log is empty on the attached zip file , which represents a folder on my server.
I created this git repo by cmd line and used it for the merge test last week.
But today I found out that I was not able to us git log any more .
I hope it can help on figuring out what happened behind the scene.
Comment 8 Susan McCourt CLA 2011-05-02 16:24:33 EDT
(In reply to comment #7)
> Git log is empty on the attached zip file , which represents a folder on my
> server.
> I created this git repo by cmd line and used it for the merge test last week.
> But today I found out that I was not able to us git log any more .
> I hope it can help on figuring out what happened behind the scene.

That sounds similar to my case, too.  The command line repo seems to work at first, and at some point it stops working.
Comment 9 Tomasz Zarna CLA 2011-05-20 07:33:23 EDT
(In reply to comment #0)
> - fresh workspace
> - linked to a subfolder of my git repo (folder org.eclipse.orion.client.core ->
> linked to
> c:\_git\orion\org.eclipse.orion.client\bundles\org.eclipse.orion.client.core)
> - select "Git Log" from org.eclipse.orion.client.core
> - success.
> - select "Git Log" from the subfolder "static"
> - empty log page.
> 
> The server reports no children.  (console screen snaps attached)

This works fine to me, as long as the change is somewhere under 'static' :) Here is what I see in the console:

GET http://localhost:8080/git/status/file/r/static/
{
  "Added": [],
  "Changed": [],
  "CommitLocation": "/git/commit/HEAD/file/r/",
  "Conflicting": [],
  "IndexLocation": "/git/index/file/r/",
  "Missing": [],
  "Modified": [{
    "Git": {
      "CommitLocation": "/git/commit/HEAD/file/r/bundles/org.eclipse.orion.client.core/static/js/auth.js",
      "DiffLocation": "/git/diff/Default/file/r/bundles/org.eclipse.orion.client.core/static/js/auth.js",
      "IndexLocation": "/git/index/file/r/bundles/org.eclipse.orion.client.core/static/js/auth.js"
    },
    "Location": "/file/r/bundles/org.eclipse.orion.client.core/static/js/auth.js",
    "Name": "bundles/org.eclipse.orion.client.core/static/js/auth.js",
    "Path": "../bundles/org.eclipse.orion.client.core/static/js/auth.js"
  }],
  "Removed": [],
  "Untracked": []
}

Please reopen the bug if you're able to change these statements "today I found out that I was not able to us git log any more ." (comment 7), "at some point it stops working." (comment 8) into a set of reproducible steps.