Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344022 - [diagram] Label editor not aligned in default node presentation
Summary: [diagram] Label editor not aligned in default node presentation
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Sapphire (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Shenxue Zhou CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2011-04-27 14:52 EDT by Konstantin Komissarchik CLA
Modified: 2021-11-19 09:22 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Komissarchik CLA 2011-04-27 14:52:04 EDT 
When the diagram uses default node presentation (a rectangle with a label in the center), the cell editor is vertically aligned with the top of the node rather than the center of the node like the label. The cell editor should always appear as close as possible to where the label is.

Also, when working on this, please constrain the width of the cell editor box so that it is offset from the node border by a few pixels on both left and right
Comment 1 Shenxue Zhou CLA 2011-06-02 17:38:13 EDT 
In the default node presentation, the label height was the same as node height and the text was centered in the rectangle using text vertical center alignment. The cell editor from direct editing wasn't able to compensate the center alignment of the text. The fix was to not increase the label height but instead place the text in the center by giving the text half of the diff between node height and text height.
Comment 2 Ram Venkataswamy CLA 2011-06-02 19:32:19 EDT 
verified with build 372
Comment 3 Konstantin Komissarchik CLA 2011-06-03 15:11:06 EDT 
Closing.