Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344013 - [diagram] Node tooltip appears for no reason
Summary: [diagram] Node tooltip appears for no reason
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Sapphire (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Ling Hao CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2011-04-27 14:28 EDT by Konstantin Komissarchik CLA
Modified: 2021-11-19 09:21 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Komissarchik CLA 2011-04-27 14:28:05 EDT
Diagram node tooltip is displayed when hovering over the node even if the label is fully visible. There is no point in that and it just serves to distract the user. The tooltip should only be displayed if a portion of the label is not visible.
Comment 1 Shenxue Zhou CLA 2011-06-07 17:28:33 EDT
Node tooltip is needed for nodes with long labels which don't fit into the space reserved for them. However, For node labels that fit, we don't need to display tooltips for them.

I've improved the logic for displaying node tooltips. Tooltips only show up when node labels are too long and when the mouse is over the label.
Comment 2 Konstantin Komissarchik CLA 2011-06-07 18:06:25 EDT
It looks like when you change node label such that you transition from "need tooltip" to "don't need tooltip" (shorten it), then tooltip is not updated. I am guessing that returning null causes tooltip to not be updated in Graphiti model as opposed to cleared. 

If I am correct and this cannot be fixed without a fix from Graphiti, it would be best to revert the change that went in and defer this to the 0.4 release.
Comment 3 Shenxue Zhou CLA 2011-06-07 18:47:22 EDT
Good catch!

My logic for calculating tooltips is correct. But there is a Graphiti bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=348662. I have provided a patch for it. Lets wait to see how soon Graphiti team can address this. My past experience is they're pretty quick in resolving bugs when patches are provided or when asked to resolve the bugs ASAP.
Comment 4 Konstantin Komissarchik CLA 2011-06-07 18:51:24 EDT
Unfortunately, Graphiti is even further along in their 0.8 release than we are. They are part of the official Indigo train and are pretty much in lock down mode...
Comment 5 Shenxue Zhou CLA 2011-06-07 18:56:23 EDT
Let's wait a couple of days on Graphiti team. Since the patch is a fairly low risk fix, they might take it. If not, I'll revert my fix.
Comment 6 Konstantin Komissarchik CLA 2011-06-07 19:03:01 EDT
Re-opening so that we don't loose track of this.
Comment 7 Shenxue Zhou CLA 2011-06-08 11:56:12 EDT
There is no time for applying patch for https://bugs.eclipse.org/bugs/show_bug.cgi?id=348662. I've reverted my change. Will have to wait for Graphiti Indigo SR1 release.
Comment 8 Konstantin Komissarchik CLA 2012-05-17 15:49:33 EDT
This one would be good to take a look at sooner rather than later... If nothing else, it would be nice to get rid of the reopened column in the 0.5 bug report.
Comment 9 Ling Hao CLA 2012-05-23 14:06:23 EDT
Add conditional check for tooltip.
Comment 10 Konstantin Komissarchik CLA 2012-05-23 14:59:28 EDT
Much better. Thanks.