Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344011 - [git][client] need better git clone progress reporting
Summary: [git][client] need better git clone progress reporting
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Git (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4 M2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-27 14:08 EDT by Susan McCourt CLA
Modified: 2012-01-31 13:21 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2011-04-27 14:08:22 EDT
I've been having trouble cloning the git orion client repo on the latest code.
I get the progress message saying it's cloning, and some git directories get created in my workspace, but nothing happens and the progress message never comes back.

Thinking I may have mistyped my credentials, I tried again with a known-to-be-bogus set of credentials.  Same symptom.

The error should return to the progress area saying that the credentials failed.  (and ideally the files that were created get cleaned up).

I think I've seen a bug like this go by, but couldn't find it.  Sorry if this is a dup.
Comment 1 Susan McCourt CLA 2011-04-27 14:16:36 EDT
I think I'm wrong about the original problem.  I think that the clone is simply taking a long time.  I tried a smaller repo (with what I thought were bogus credentials) and it worked, which makes sense because I assume the clone itself can happen without credentials.

So, I'll rename this bug and suggest that we actually try to report some kind of progress back from the server, even it's just a "still transferring" files and some timestamp that would show me that it's still working.
Comment 2 Susan McCourt CLA 2011-04-27 16:34:43 EDT
The clone took 32 minutes.
I followed progress by going to the .git/objects directory in the cloned folder and periodically checking its size...
Comment 3 John Arthorne CLA 2011-04-27 16:39:59 EDT
(In reply to comment #2)
> The clone took 32 minutes.
> I followed progress by going to the .git/objects directory in the cloned folder
> and periodically checking its size...

That sounds awful, but could you post the clone time when using the command line or eGit, for reference? You are a good test case because the remote git repository is in Ottawa, which is close for me but far for you. If we are significantly worse than eGit or command line we might need to dig into that.
Comment 4 John Arthorne CLA 2011-04-27 16:44:11 EDT
I should also mention that jgit API has no facility for progress reporting, so I'm not sure we can give accurate progress update messages or % completion from the server. I suppose we could send something like elapsed time so you know we're not dead.
Comment 5 Susan McCourt CLA 2011-04-28 10:30:13 EDT
(In reply to comment #4)
> I should also mention that jgit API has no facility for progress reporting, so
> I'm not sure we can give accurate progress update messages or % completion from
> the server. I suppose we could send something like elapsed time so you know
> we're not dead.

Yes, exactly, elapsed time would have been great.  In bug 344012 when I had multiple clones updating the progress area, that was the first significant clue that my clone was still working.  Since the same message gets posted right now during a clone, you can't tell that it's still doing anything.
Comment 6 Susan McCourt CLA 2011-04-28 10:30:57 EDT
(In reply to comment #3)
> (In reply to comment #2)
> > The clone took 32 minutes.
> > I followed progress by going to the .git/objects directory in the cloned folder
> > and periodically checking its size...
> 
> That sounds awful, but could you post the clone time when using the command
> line or eGit, for reference? You are a good test case because the remote git
> repository is in Ottawa, which is close for me but far for you. If we are
> significantly worse than eGit or command line we might need to dig into that.

I will try this today.  The same clone later in the day was 25 min or so.  Eclipse.org seemed very slow in general during that time.
Comment 7 Susan McCourt CLA 2011-04-28 11:22:39 EDT
opened bug 344143 for performance discussion.

(and for the record, git gui has no progress during a clone either....)
Comment 8 Malgorzata Janczarska CLA 2012-01-23 05:10:16 EST
Susan, is this bug still present? The new progress service keeps the task in the list as long as it's running and a little longer. For old tasks you can go to operations page and see what was their result.
Comment 9 Susan McCourt CLA 2012-01-23 12:38:13 EST
yes, this is fixed by the new operations task list.  The problem before was just seeing that static message and not knowing if anything was happening.  Now I can look at the time started and status in the ops list.