Community
Participate
Working Groups
Based on build from /e4/sdk/drops/I20110425-0200/eclipse-SDK-I20110425-0200-win32.zip In WTP we routinely run "layout" releng tests ... one of which checks for presence of "about.html" files in each bundle. Normally I put in "ignore clauses" for bundles outside of WTP ... but, before I do that for e4, wanted to report these to you in case it helps you. The first two ... missing "nls properties" is sometimes a sign a bundle has not had its strings externalized (but, not always required, so those two may be false alarms). The remaining 19 messages from our releng test, indicates the e4 "source bundles" still need an about.html file in them. (Usually accomplished with a 'sourceTemplateBundle' directory in a feature, as I'm sure you know ... or is it 'sourceTemplatePlugin' I always get them confused). Anyway ... just reporting in case it helps you avoid a last minute "legal problem" ... and I'll remove from our WTP checks now :) 1. Missing pattern or file: .*(plugin|bundle|OSGI-INF/l10n/bundle).properties in file: org.eclipse.e4.core.di.extensions.source_0.9.0.v20101122-2200.jar 2. Missing pattern or file: .*(plugin|bundle|OSGI-INF/l10n/bundle).properties in file: org.eclipse.e4.core.di.extensions_0.9.0.v20101122-2200.jar 3. Missing pattern or file: about.html in file: org.eclipse.e4.core.commands.source_0.9.0.v20110414-2200.jar 4. Missing pattern or file: about.html in file: org.eclipse.e4.core.contexts.debug.source_0.1.0.v20110203-2200.jar 5. Missing pattern or file: about.html in file: org.eclipse.e4.core.contexts.source_0.9.0.v20101125-1630.jar 6. Missing pattern or file: about.html in file: org.eclipse.e4.core.di.extensions.source_0.9.0.v20101122-2200.jar 7. Missing pattern or file: about.html in file: org.eclipse.e4.core.di.source_0.9.0.v20110407-2030.jar 8. Missing pattern or file: about.html in file: org.eclipse.e4.core.services.source_0.9.1.v20110113-1500.jar 9. Missing pattern or file: about.html in file: org.eclipse.e4.emf.xpath.source_1.0.0.v20110312-8000.jar 10. Missing pattern or file: about.html in file: org.eclipse.e4.ui.bindings.source_0.9.0.v20110320-2300.jar 11. Missing pattern or file: about.html in file: org.eclipse.e4.ui.css.core.source_0.9.0.v20110414-2200.jar 12. Missing pattern or file: about.html in file: org.eclipse.e4.ui.css.swt.source_0.9.1.v20110407-2030.jar 13. Missing pattern or file: about.html in file: org.eclipse.e4.ui.di.source_0.9.0.v20110303-1630.jar 14. Missing pattern or file: about.html in file: org.eclipse.e4.ui.model.workbench.source_0.9.1.v20110420-1900.jar 15. Missing pattern or file: about.html in file: org.eclipse.e4.ui.services.source_0.9.1.v20110303-1630.jar 16. Missing pattern or file: about.html in file: org.eclipse.e4.ui.widgets.source_1.0.0.v20110419-1940.jar 17. Missing pattern or file: about.html in file: org.eclipse.e4.ui.workbench.addons.swt.source_0.9.0.v20110422-1900.jar 18. Missing pattern or file: about.html in file: org.eclipse.e4.ui.workbench.renderers.swt.source_0.9.1.v20110422-1900.jar 19. Missing pattern or file: about.html in file: org.eclipse.e4.ui.workbench.source_0.9.1.v20110422-1900.jar 20. Missing pattern or file: about.html in file: org.eclipse.e4.ui.workbench.swt.source_0.9.1.v20110422-1900.jar 21. Missing pattern or file: about.html in file: org.eclipse.e4.ui.workbench3.source_1.0.0.v20100720-1930.jar
Thanks David. We have releng tests that check for that but I don't think they run in the 4.1 builds yet. Looks like most of these bundles are missing src.includes in their build.properties
These two contain a fragment.properties file. David, perhaps you could add "fragment.properties" as one of the valid bundle localization property files? 1. Missing pattern or file: .*(plugin|bundle|OSGI-INF/l10n/bundle).properties in file: org.eclipse.e4.core.di.extensions.source_0.9.0.v20101122-2200.jar 2. Missing pattern or file: .*(plugin|bundle|OSGI-INF/l10n/bundle).properties in file: org.eclipse.e4.core.di.extensions_0.9.0.v20101122-2200.jar
Fixed the remaining problems.
(In reply to comment #2) > These two contain a fragment.properties file. David, perhaps you could add > "fragment.properties" as one of the valid bundle localization property files? > Well, I've never heard of such a thing! :) (Since I normally don't work with fragments.) While I've removed all e4 bundles from our WTP tests, it'll be good to be prepared. Thanks.
