Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343960 - [Formatter] FormattingConfigBasedStream produces only hidden tokens
Summary: [Formatter] FormattingConfigBasedStream produces only hidden tokens
Status: CLOSED WONTFIX
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext Backlog (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-27 09:58 EDT by Lieven Lemiengre CLA
Modified: 2016-07-21 05:15 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lieven Lemiengre CLA 2011-04-27 09:58:57 EDT 
Build Identifier:  I20110310-1119

FormattingConfigBasedStream should keep the 'hidden' property of tokens intact.

In FormattingConfigBasedStream.addLineEntry at line 367:

LineEntry e = createLineEntry(grammarElement, value, true, locators, preservedWS, indentationLevel, hiddenTokenDef);

should be
 
LineEntry e = createLineEntry(grammarElement, value, isHidden, locators, preservedWS, indentationLevel, hiddenTokenDef);

Reproducible: Always

Steps to Reproduce:
-
Comment 1 Moritz Eysholdt CLA 2016-07-21 05:15:36 EDT 
won't fix because it affects the old formatter infrastructure