Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343899 - Cannot exclude added/removed bundles from API freeze check
Summary: Cannot exclude added/removed bundles from API freeze check
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M7   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-26 15:09 EDT by Olivier Thomann CLA
Modified: 2011-04-27 15:46 EDT (History)
2 users (show)

See Also:
Michael_Rennie: review+


Attachments
Proposed fix (1.47 KB, patch)
2011-04-26 15:17 EDT, Olivier Thomann CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2011-04-26 15:09:10 EDT
It is not possible to exclude added/removed bundles from API freeze check. We should add support for this.
Comment 1 Olivier Thomann CLA 2011-04-26 15:17:03 EDT
Created attachment 194091 [details]
Proposed fix
Comment 2 Olivier Thomann CLA 2011-04-27 12:44:28 EDT
Michael, please review. This would be needed to get rid of the first three lines in the API freeze check.
Comment 3 Michael Rennie CLA 2011-04-27 15:43:45 EDT
Patch looks good. All tests pass.

Also a good candidate for 3.7M7 to ensure the correctness of the freeze report.
Comment 4 Michael Rennie CLA 2011-04-27 15:44:36 EDT
applied patch to HEAD
Comment 5 Michael Rennie CLA 2011-04-27 15:46:11 EDT
verified.

The new exclude entries have the format:

ADDED#component_id

or

REMOVED#component_id