343892 – use content-type icons in attachment table and input

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343892 - use content-type icons in attachment table and input

Summary: use content-type icons in attachment table and input

Status:	RESOLVED FIXED

Alias:	None

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	Mylyn (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P3 enhancement (vote)
Target Milestone:	3.6
Assignee:	Kevin Sawicki
QA Contact:

URL:
Whiteboard:
Keywords:	contributed, noteworthy

Depends on:
Blocks:

Reported:	2011-04-26 14:38 EDT by Kevin Sawicki
Modified:	2011-05-15 15:51 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
Patch (1.89 KB, patch) 2011-04-26 14:42 EDT, Kevin Sawicki	no flags	Details \| Diff
Screenshot of after patch (108.39 KB, image/png) 2011-04-26 14:44 EDT, Kevin Sawicki	no flags	Details
Screenshot of before patch (105.26 KB, image/png) 2011-04-26 14:45 EDT, Kevin Sawicki	no flags	Details
Patch to support content-type icons (2.78 KB, patch) 2011-04-26 15:03 EDT, Kevin Sawicki	steffen.pingel: iplog+	Details \| Diff
Test Case (1 bytes, text/plain) 2011-05-15 15:48 EDT, Steffen Pingel	no flags	Details
screenshot (14.67 KB, image/png) 2011-05-15 15:51 EDT, Steffen Pingel	no flags	Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Kevin Sawicki

2011-04-26 14:38:45 EDT

The attachment table label provider and attachment file editor input don't
support content-type icons for the file types displayed.

For example a file Main.java doesn't have the Java editor icon when present
in the attachments table or when opened in an editor using the
attachment file editor input class.

Comment 1 Kevin Sawicki

2011-04-26 14:42:42 EDT

Created attachment 194087 [details]
Patch

Patch to use editor registry image descriptor in attachments table label provider and return path from attachment file editor input factory which causes icons to be displayed in editor.

Comment 2 Kevin Sawicki

2011-04-26 14:44:29 EDT

Created attachment 194088 [details]
Screenshot of after patch

Comment 3 Kevin Sawicki

2011-04-26 14:45:33 EDT

Created attachment 194089 [details]
Screenshot of before patch

Comment 4 Kevin Sawicki

2011-04-26 15:03:12 EDT

Created attachment 194090 [details]
Patch to support content-type icons

Comment 5 Steffen Pingel

2011-05-07 19:38:45 EDT

Great patch! I have applied it to head.

Comment 6 Steffen Pingel

2011-05-15 15:48:45 EDT

Created attachment 195676 [details]
Test Case

Comment 7 Steffen Pingel

2011-05-15 15:51:13 EDT

Created attachment 195677 [details]
screenshot