Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343867 - EvaluationContextManager unnecessarily triggers loading of org.eclipse.cdt.debug.ui
Summary: EvaluationContextManager unnecessarily triggers loading of org.eclipse.cdt.de...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf (show other bugs)
Version: 7.0.2   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 8.0   Edit
Assignee: Pawel Piech CLA
QA Contact: Pawel Piech CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-26 11:10 EDT by Pawel Piech CLA
Modified: 2011-05-19 20:45 EDT (History)
3 users (show)

See Also:
marc.khouzam: review+

Attachments
Patch with simple fix. (1.67 KB, patch)
2011-04-26 12:06 EDT, Pawel Piech CLA 		cdtdoug: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Piech CLA 2011-04-26 11:10:47 EDT 
The EvaluationContextManager, which is used to activate several actions in the UI, references org.eclipse.cdt.debug.ui in the following statement:

	private final static String DEBUGGER_ACTIVE = CDebugUIPlugin.getUniqueIdentifier() + ".debuggerActive"; //$NON-NLS-1$


This triggers activating the org.eclipse.cdt.debug.ui plugin as soon as the dsf.ui plugin is activated.  This dependency is not necessary.
Comment 1 Pawel Piech CLA 2011-04-26 12:06:26 EDT 
Created attachment 194072 [details]
Patch with simple fix.
Comment 2 Pawel Piech CLA 2011-04-26 12:18:55 EDT 
I committed the change.  Marc, please review.
Comment 3 CDT Genie CLA 2011-04-26 12:23:15 EDT 
*** cdt cvs genie on behalf of ppiech ***
Bug 343867 - EvaluationContextManager unnecessarily triggers loading of org.eclipse.cdt.debug.ui

[*] EvaluationContextManager.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/EvaluationContextManager.java?root=Tools_Project&r1=1.1&r2=1.2
Comment 4 Marc Khouzam CLA 2011-04-26 13:18:19 EDT 
Nice catch!
Comment 5 Marc Khouzam CLA 2011-05-03 10:11:42 EDT 
Pawel, should we mark this as fixed?
Comment 6 Pawel Piech CLA 2011-05-06 16:11:15 EDT 
(In reply to comment #5)
> Pawel, should we mark this as fixed?

Yes, My bad.