Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343854 - Web Application to Workbench Examples
Summary: Web Application to Workbench Examples
Status: RESOLVED WONTFIX
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-26 10:26 EDT by Dean Roberts CLA
Modified: 2015-05-05 16:20 EDT (History)
9 users (show)

See Also:


Attachments
New zipped Eclipse project including shared launch config (29.58 KB, application/force-download)
2011-04-26 10:27 EDT, Dean Roberts CLA
no flags Details
Cosmetic patch to link intercept exampe (8.42 KB, patch)
2011-04-27 10:31 EDT, Dean Roberts CLA
no flags Details | Diff
Orion text editor embedded in Eclipse (491.48 KB, application/zip)
2011-05-18 15:41 EDT, Dean Roberts CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Roberts CLA 2011-04-26 10:26:18 EDT
Build Identifier: 

I've started writing some example code to illustrate how to perform some interesting workbench integration of web applications.

Currently the example demonstrates Link Interception to open views and wizards.  But it is also a small framework on which to add future examples such as editor life cycle, authentication, context menu substitution and the like.

I will be blogging these examples but need a place for the code to live.

Reproducible: Always
Comment 1 Dean Roberts CLA 2011-04-26 10:27:32 EDT
Created attachment 194059 [details]
New zipped Eclipse project including shared launch config

Boris, could you please take a look.
Comment 2 Boris Bokowski CLA 2011-04-26 11:34:51 EDT
John found the official word on licensing example code. See
http://eclipse.org/org/documents/Licensing_Example_Code.pdf

John, we need PMC approval for using the EDL. OK to do this in this example
project? Dean will be adding new examples over the next little while.

For the copyright header, does the following look reasonable?

/** Copyright 2011 IBM and others.
This Example Content is intended to demonstrate usage of Eclipse technology. It
is provided to you under the terms and conditions of the Eclipse Distribution
License v1.0 which is available at
http://www.eclipse.org/org/documents/edl-v10.php
**/
Comment 3 John Arthorne CLA 2011-04-26 11:40:38 EDT
That looks good to me. I'll bring it up at the PMC call this week just to make sure we're all on the same page. If the example is distributed in a bundle/feature then we also need to ensure the about.html, license, etc, are correct.
Comment 4 Boris Bokowski CLA 2011-04-26 15:35:32 EDT
I've committed the code into the e4 CVS under e4/org.eclipse.e4.ui/examples as a new project org.eclipse.e4.examples.webintegration.

I made a few changes, the two main ones were:
 - changed the name of the project and the packages
 - removed the dependency on org.eclipse.ui.ide and org.eclipse.core.resources
Comment 5 Dean Roberts CLA 2011-04-27 10:31:50 EDT
Created attachment 194160 [details]
Cosmetic patch to link intercept exampe

Boris,

Could you please apply this patch.  It simply removes the commented out code that was creating an instance of NewFileWizard.
Comment 6 Boris Bokowski CLA 2011-04-27 10:37:39 EDT
(In reply to comment #5)
> Could you please apply this patch.  It simply removes the commented out code
> that was creating an instance of NewFileWizard.

done.
Comment 7 Dean Roberts CLA 2011-05-18 15:41:03 EDT
Created attachment 196043 [details]
Orion text editor embedded in Eclipse

Here is an example plug-in that embeds an Orion text editor in an Eclipse workbench.  Could you please commit as I'm waiting for my commit rights to be finalized.
Comment 9 Paul Webster CLA 2013-09-06 13:42:15 EDT
See also what was done in bug 410841

PW
Comment 10 Angelo ZERR CLA 2013-09-19 17:03:56 EDT
(In reply to Paul Webster from comment #9)
> See also what was done in bug 410841
> 
> PW

As OrionControl seems to please you (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=417315), I would like to experiment to develop a pur E4 Editor (like 3.x ViewPart) which will use OrionControl to manage CSS editor with Orion and I would like to know if your are interested with that.

I have a little experience with that because I have developped a 3.x ViewPart in my CodeMirror-Eclipse project (https://github.com/angelozerr/CodeMirror-Eclipse).

On other words, I would like to provide an Editor Part with Orion : 

1) support Eclipse RCP/RAP. The editor can be loaded for instance from a java.io.File.
2) support Eclipse IDE. The editor can be loaded from Eclipse IFile.
3) provides a Find/Replace dialog which will work in any context (Java Main with SWT, RCP, IDE). I have done that by developping my own Find/Replace dialog, but I think Find/Replace dialog could be an E4 service that you could inject in your E4 editor (or other thing).
4) provides an implementation of IGotoMarker for the E4 Orion Editor Part. This is usefull when you use classic Search dialog and you double click on a result to open the Orion editor and select the content.

Tell me if you are interested with those ideas.

Regards Angelo
Comment 11 Paul Webster CLA 2013-09-27 09:44:09 EDT
(In reply to Angelo ZERR from comment #10)
> On other words, I would like to provide an Editor Part with Orion : 
> 
> 1) support Eclipse RCP/RAP. The editor can be loaded for instance from a
> java.io.File.
> 2) support Eclipse IDE. The editor can be loaded from Eclipse IFile.
> 3) provides a Find/Replace dialog which will work in any context (Java Main
> with SWT, RCP, IDE). I have done that by developping my own Find/Replace
> dialog, but I think Find/Replace dialog could be an E4 service that you
> could inject in your E4 editor (or other thing).
> 4) provides an implementation of IGotoMarker for the E4 Orion Editor Part.
> This is usefull when you use classic Search dialog and you double click on a
> result to open the Orion editor and select the content.

This all sounds like good functionality to have.  Our main focus on this bug is a 3.x compatible editor part that can serve as an editor for js, json, css, and html.

PW
Comment 12 John Arthorne CLA 2015-05-05 16:20:22 EDT
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:


https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html