Community
Participate
Working Groups
Build Identifier: Similar to how encoding is set for Java sources (issue #340507) folder, I think that the encoding should be automatically set for resources folders. I suggest that the encoding configured for resources:resources and resources:testResources should be used. It is highly unlikely that different encoding is configured for those two goals, but it is possible configuration wise. Reproducible: Always Steps to Reproduce: 1. Create a Maven project 2. Right-click on src/main/resources folder and select 'Properties' 3. For Text file encoding it states "Inherited from container" which most likely will be the wrong encoding for your Maven project
There is one slight difference between encoding configured for maven-compiler-plugin and maven-resources-plugin. For the resources plugin, the encoding is only used when doing filtering. But I still think that the configured encoding is a safe guess for any created file in that folder, even though filtering isn't configured for it. Do you agree?
slightly unrelated but as far as I remember, netbeans is using the the maven encoding for resources as well. The encoding property (project.build.sourceEncoding) is even used from the project customizer UI to change the "project" encoding. if the maven definition is not present, it falls back to OS platform specific default.
(In reply to comment #2) > slightly unrelated but as far as I remember, netbeans is using the the maven > encoding for resources as well. The encoding property > (project.build.sourceEncoding) is even used from the project customizer UI to > change the "project" encoding. if the maven definition is not present, it falls > back to OS platform specific default. Filed bug 343927 for this enhancement.
Created attachment 194233 [details] Patch in git format I've attached a patch for this, heavily influence by the patch for bug 340507. I have tested it manually and will continue to work on integration tests for it.
Created attachment 194256 [details] Updated patch Retry: attached an updated patch which should be in correct git format
I sent a pull request in Github for the integration tests.
Created attachment 194272 [details] integration tests Patch file for integration tests added, replacing the pull request sent in Github.
Applied the patch with minor fixes to one of test projects (was missing extra resource folders). Thank you.
Comment on attachment 194256 [details] Updated patch cleaning IP Log up
Moved to https://github.com/eclipse-m2e/m2e-core/issues/