Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343780 - Infinite recursive call in Zookeeper DiscoveryActivator
Summary: Infinite recursive call in Zookeeper DiscoveryActivator
Status: RESOLVED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.discovery (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5.1   Edit
Assignee: Wim Jongman CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-25 19:29 EDT by Ajay CLA
Modified: 2011-04-27 17:52 EDT (History)
4 users (show)

See Also:

Attachments
mylyn/context/zip (1.53 KB, application/octet-stream)
2011-04-27 17:52 EDT, Wim Jongman CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ajay CLA 2011-04-25 19:29:32 EDT 
Build Identifier: 1.0.100.v20110313-1843

See line 78: removedService(reference, service)


75: public void removedService(ServiceReference reference,
76:		Object service) {
77:     Logger.unbindLogService((LogService) service);
78:     removedService(reference, service);
79:     super.removedService(reference, service); 
80: }

This leads to a StackOverflowError

java.lang.StackOverflowError
	at org.eclipse.ecf.provider.zookeeper.util.Logger.unbindLogService(Logger.java:34)
	at org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:77)
	at org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
	at org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
	at org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
	at org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
	at org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
	at org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
	at org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
	at org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)

Reproducible: Always
Comment 1 Ajay CLA 2011-04-25 19:30:31 EDT 
in plugin:
org.eclipse.ecf.provider.zookeeper_1.0.100.v20110313-1843
Comment 2 Scott Lewis CLA 2011-04-25 20:01:11 EDT 
Thanks Ajay for the report.

Adding Markus, Wim, and Ahmed for comment.
Comment 3 Ahmed Aadel CLA 2011-04-26 04:14:47 EDT 
misplaced and uneeded recursive line:
78:     removedService(reference, service);
It should, simply, be dropped. 

(In reply to comment #0)
> Build Identifier: 1.0.100.v20110313-1843
> See line 78: removedService(reference, service)
> 75: public void removedService(ServiceReference reference,
> 76:        Object service) {
> 77:     Logger.unbindLogService((LogService) service);
> 78:     removedService(reference, service);
> 79:     super.removedService(reference, service); 
> 80: }
> This leads to a StackOverflowError
> java.lang.StackOverflowError
>     at
> org.eclipse.ecf.provider.zookeeper.util.Logger.unbindLogService(Logger.java:34)
>     at
> org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:77)
>     at
> org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
>     at
> org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
>     at
> org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
>     at
> org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
>     at
> org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
>     at
> org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
>     at
> org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
>     at
> org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
> Reproducible: Always
Comment 4 Wim Jongman CLA 2011-04-27 17:52:22 EDT 
Fixed and released to master. Thank you for reporting this.
Comment 5 Wim Jongman CLA 2011-04-27 17:52:23 EDT 
Created attachment 194217 [details]
mylyn/context/zip