Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343735 - Consider to use more fine-grained locking
Summary: Consider to use more fine-grained locking
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.1 M5   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-25 10:26 EDT by Rüdiger Herrmann CLA
Modified: 2016-03-01 04:38 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rüdiger Herrmann CLA 2011-04-25 10:26:48 EDT 
In order to make critical sections thread safe, we currently lock access using single synchronized blocks for read and write access. Performance in these areas could benefit from differenciating between read and write access and use distinct locks.
If it turns out that performce gains can be made, I see two options:
* org.eclipse.equinox.registry has an internal ReadWriteMonitor that we could adopt
* Java 1.5 provides the ReentrantReadWriteLock (depends on bug bug 340310)
Comment 1 Greg Bishop CLA 2013-06-24 09:34:54 EDT 
Q: Could you also please consider making is so the editors themselved son't block at all, perhpas by giving them a seperate thread so the user can save and edit files without ever waiting on the IDE?
Comment 2 Ivan Furnadjiev CLA 2016-03-01 04:38:25 EST 
The ReentrantReadWriteLock has been used in the most sensitive place with change https://git.eclipse.org/r/#/c/63150/.