Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343706 - improve logging / error messages from CertificateChecker
Summary: improve logging / error messages from CertificateChecker
Status: CLOSED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: Juno M2   Edit
Assignee: Pascal Rapicault CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-24 12:27 EDT by Volker Wegert CLA
Modified: 2011-08-12 19:08 EDT (History)
1 user (show)

See Also:

Attachments
proposed patch (5.83 KB, patch)
2011-04-24 18:14 EDT, Volker Wegert CLA 		pascal: iplog+
Details | Diff
example of trace output after applying the patch (10.72 KB, text/plain)
2011-04-24 18:15 EDT, Volker Wegert CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Volker Wegert CLA 2011-04-24 12:27:52 EDT 
Build Identifier: 20110301-1815

If something goes wrong when checking the certificates (org.eclipse.equinox.internal.p2.engine.phases.CertificateChecker), virtually no information is available about the cause of the problem. In my case, it took me forever to find out why the p2.director of a headless build was unable to install bundles. 

Proposal: Add another trace switch (similar to org.eclipse.equinox.p2.core/generator/parsing, ...) and log all unsigned and untrusted objects in CertificateChecker.checkCertificates() before returning the status if that trace option is set. 

Reproducible: Always
Comment 1 Volker Wegert CLA 2011-04-24 18:14:50 EDT 
Created attachment 193974 [details]
proposed patch
Comment 2 Volker Wegert CLA 2011-04-24 18:15:16 EDT 
Created attachment 193975 [details]
example of trace output after applying the patch
Comment 3 Pascal Rapicault CLA 2011-05-17 20:14:38 EDT 
Hi, I'm sorry to only get to this now. It felt through the cracks. Would you be able to provide an updated version of the patch since it does not seem to apply anymore. Thx in advance.
Comment 4 Pascal Rapicault CLA 2011-08-12 19:07:38 EDT 
I managed to apply the patch.
Comment 5 Pascal Rapicault CLA 2011-08-12 19:08:13 EDT 
Comment on attachment 193974 [details]
proposed patch

Thx for the contribution