343700 – Exceptions during Build Selected Files operation are not displayed in the Build Console

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343700 - Exceptions during Build Selected Files operation are not displayed in the Build Console

Summary: Exceptions during Build Selected Files operation are not displayed in the Bui...

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-build-managed (show other bugs)
Version:	7.0.1
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	7.0.3
Assignee:	Andrew Gvozdev
QA Contact:	Chris Recoskie

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-04-24 07:43 EDT by Alex Freidin
Modified:	2011-04-27 03:31 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
Patch (3.05 KB, patch) 2011-04-24 07:49 EDT, Alex Freidin	angvoz.dev: iplog+	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alex Freidin

2011-04-24 07:43:24 EDT

Build Identifier: M20100909-0800

If there is an exception during Build Selected Files operation, the Internal Builder doesn't print the error message to the Build Console and doesn't close the console streams. The exception handling in GeneratedMakefileBuilder.invokeInternalBuilder(IResource[] resourcesToBuild, IConfiguration...) is incomplete.

Reproducible: Always

Comment 1 Alex Freidin

2011-04-24 07:49:03 EDT

Created attachment 193965 [details]
Patch

Added the missing exception handling from the sibling method: invokeInternalBuilder(IConfiguration cfg, ...)
Patch is based on CDT 7.0.1 sources, but relevant also for HEAD (1.82 version of the file).

Comment 2 Andrew Gvozdev

2011-04-26 18:36:49 EDT

Committed on HEAD and 7.0.X with some beautification stuff if I can call it that. Thanks for the patch.

Comment 3 CDT Genie

2011-04-26 19:23:01 EDT

*** cdt cvs genie on behalf of agvozdev ***
bug 343700: Exceptions during Build Selected Files operation are not displayed in the Build Console
Patch from Alex Freidin

[*] GeneratedMakefileBuilder.java 1.83 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/GeneratedMakefileBuilder.java?root=Tools_Project&r1=1.82&r2=1.83

[*] GeneratedMakefileBuilder.java 1.78.2.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/GeneratedMakefileBuilder.java?root=Tools_Project&r1=1.78.2.3&r2=1.78.2.4

Comment 4 Alex Freidin

2011-04-27 03:31:12 EDT

Thanks for applying!