Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343662 - [PlatformConfiguration] Handle null URI better
Summary: [PlatformConfiguration] Handle null URI better
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Runtime (show other bugs)
Version: 3.7   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 trivial (vote)
Target Milestone: 4.8 M3   Edit
Assignee: Karsten Thoms CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-22 13:02 EDT by Karsten Thoms CLA
Modified: 2017-10-13 00:04 EDT (History)
1 user (show)

See Also:


Attachments
Screenshot: Debugger #1 (314.33 KB, image/png)
2011-04-22 13:02 EDT, Karsten Thoms CLA
no flags Details
Screenshot: Debugger #2 (307.78 KB, image/png)
2011-04-22 13:02 EDT, Karsten Thoms CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Karsten Thoms CLA 2011-04-22 13:02:30 EDT
Created attachment 193932 [details]
Screenshot: Debugger #1

The constructor PlatformConfiguration(URL) just catches all exceptions with empty catch clause. One obvious exception that can occur is that the URL argument is null. This should be handled better. I usually have an exception breakpoint on NullPointerException and did not expect that it popped up here. The concrete situation was that the code was indirectly called by UpdateHelpManager#createPlatformConfiguration(), which calls the code always with a null URL.

See attached screenshots for the debugger.
Comment 1 Karsten Thoms CLA 2011-04-22 13:02:49 EDT
Created attachment 193933 [details]
Screenshot: Debugger #2
Comment 2 Eclipse Genie CLA 2017-09-19 11:07:55 EDT
New Gerrit change created: https://git.eclipse.org/r/105408
Comment 4 Lars Vogel CLA 2017-10-13 00:04:28 EDT
Thanks, Karsten.