Comment 1 Malgorzata Janczarska 2011-04-22 11:05:07 EDT

Created attachment 193916 [details]
Display information in the error dialog

This patch moves the information message to the error dialog.
See Bug 319661 comment #54 for remarks to this bug.

Comment 2 Dani Megert 2011-04-25 12:03:18 EDT

Not critical enough to be addressed during RC*.

Comment 3 Malgorzata Janczarska 2012-03-05 08:23:53 EST

Patch pushed to Gerrit: https://git.eclipse.org/r/#/c/5242/

Comment 4 Malgorzata Janczarska 2012-03-13 12:18:04 EDT

Created attachment 212572 [details]
Old "No differences found" dialog

Comment 5 Malgorzata Janczarska 2012-03-13 12:18:51 EDT

Created attachment 212573 [details]
New "No differences found" dialog

Comment 6 Malgorzata Janczarska 2012-03-13 12:30:00 EDT

Please go to Gerrit: https://git.eclipse.org/r/#/c/5242/ for the new version of patch.
I used StatusManager to handle displaying messages. This has two advantages:
1. The "No differences found" is not shown as an extra dialog. If there where errors while creating patch they are reported altogether in one error dialog. "No differences found" is also part of this dialog.
2. Previously if we where creating patch for 4 projects and all of them failed we used to get 4 error message dialogs. Now we get only one dialog with all 4 errors.

But in result of this we have a visual change in reporting messages, even if we don't get any errors the "No differences found" info differs. See attachment 212572 [details] for the old version of the dialog and attachment 212573 [details] of the new version. I also changed it's title to "CVS diff is empty" as in the new version I think "CVS diff" is not sufficient. If this change is not acceptable I may create a simple "if" to avoid changing the "No differences found" if there where no errors.

Comment 7 Dani Megert 2012-04-20 06:38:39 EDT

> Please go to Gerrit: https://git.eclipse.org/r/#/c/5242/ for the new version 
> of patch.

Ping! Review has been made a while ago ;-).

Comment 8 Malgorzata Janczarska 2012-04-20 07:00:19 EDT

(In reply to comment #7)
> > Please go to Gerrit: https://git.eclipse.org/r/#/c/5242/ for the new version 
> > of patch.
> 
> Ping! Review has been made a while ago ;-).

Sorry, please give me some more time, I'm loaded with other also important work currently.

Comment 9 Szymon Brandys 2012-05-02 10:16:45 EDT

(In reply to comment #8)
> (In reply to comment #7)
> > > Please go to Gerrit: https://git.eclipse.org/r/#/c/5242/ for the new version 
> > > of patch.
> > 
> > Ping! Review has been made a while ago ;-).
> 
> Sorry, please give me some more time, I'm loaded with other also important work
> currently.

The suggested adjustment seems to be easy to apply. Gosia, redo the patch and ask Dani for review again, please.

Comment 10 Malgorzata Janczarska 2012-06-28 06:40:58 EDT

I can see it has been merged in 492c044a64ed6b8a6a07fd7bbc4be551487791ac. Thanks Dani.

Comment 11 Tomasz Zarna 2012-06-28 06:50:38 EDT

(In reply to comment #10)
> I can see it has been merged in 492c044a64ed6b8a6a07fd7bbc4be551487791ac.

Is the target milestone correct? The change has been merged in on June 14, that would mean 3.8, right?

Comment 12 Dani Megert 2012-06-28 06:57:28 EDT

(In reply to comment #11)
> (In reply to comment #10)
> > I can see it has been merged in 492c044a64ed6b8a6a07fd7bbc4be551487791ac.
> 
> Is the target milestone correct? The change has been merged in on June 14, that
> would mean 3.8, right?
No, it's in 4.3.