Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343655 - CharComposite : magic numbers
Summary: CharComposite : magic numbers
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-22 10:29 EDT by Nicolas Bros CLA
Modified: 2020-05-01 11:27 EDT (History)
3 users (show)

See Also:
nicolas.bros: indigo+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2011-04-22 10:29:56 EDT 
There are 2 constants defined with magic numbers (127 and 8) in org.eclipse.emf.facet.widgets.celleditors.ecore.composite.CharComposite.

127 corresponds to SWT.DEL, so the SUPPR_KEYCODE ("suppr" is french for "del" by the way) constant can be replaced by SWT.DEL.

As for the DEL_KEYCODE, defined as 8, I don't know what it corresponds to, as it is not defined in SWT. Does the keyCode ever take this value?
Comment 1 Nicolas Guyomar CLA 2011-04-22 10:36:05 EDT 
DEL_KEYCODE, defined as 8, correspond the the "BACKSPACE" key on my keyboard
Comment 2 Nicolas Bros CLA 2011-04-22 10:41:46 EDT 
(In reply to comment #1)
> DEL_KEYCODE, defined as 8, correspond the the "BACKSPACE" key on my keyboard

Ok. So it should be SWT.BS, which is defined as '\b' and which is equal to 8.
Comment 3 Nicolas Bros CLA 2011-04-26 05:11:20 EDT 
Fixed in revision 572.
Comment 4 Gregoire Dupe CLA 2011-06-08 11:05:01 EDT 
CharComposite does not define any constants. This bug can then be closed.