Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343644 - [server] Git Log should return branches for commits
Summary: [server] Git Log should return branches for commits
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Git (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.3 M1   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard: gsoc2011
Keywords:
Depends on: 341384
Blocks: 353088
  Show dependency tree
 
Reported: 2011-04-22 05:01 EDT by Tomasz Zarna CLA
Modified: 2012-01-19 10:59 EST (History)
2 users (show)

See Also:
tomasz.zarna: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2011-04-22 05:01:02 EDT 
Bug 343386 added list of tags for a given commit in Git Log. This bug is for adding a similar information about branches.
Comment 1 Piotr Janik CLA 2011-07-26 19:08:36 EDT 
GitLogTest.testLogWithTag() assumes that branches will be kept together with tags in Children field. Is it a good idea?
If we divide these things in the response (i.e. another field for branches), we can show them separately in the UI. I think that this'll be clearer, especially for inexperienced Git users.
Comment 2 Piotr Janik CLA 2011-07-26 19:09:20 EDT 
Ofc I was thinking about testLogWithBranch(), not testLogWithTag().
Comment 3 Tomasz Zarna CLA 2011-07-27 05:51:56 EDT 
I'm fine with dividing the current "Children" field into separate fields e.g. "Tags" and "Branches". I don't think keeping them together is a good idea either.
Comment 4 Piotr Janik CLA 2011-07-27 06:23:56 EDT 
https://github.com/pjanik/orion.server/tree/bug343644

I wrote all this code and have the rights to contribute it to Eclipse under the
eclipse.org web site terms of use.