Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343573 - Update the error handling of scid to deal with the socket exception
Summary: Update the error handling of scid to deal with the socket exception
Status: CLOSED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: SCI (show other bugs)
Version: unspecified   Edit
Hardware: All Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: rong li CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-21 12:11 EDT by rong li CLA
Modified: 2012-11-06 05:07 EST (History)
1 user (show)

See Also:

Attachments
Submit the patch for updating the error handling of scid (1.03 KB, patch)
2011-04-21 12:15 EDT, rong li CLA 		g.watson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description rong li CLA 2011-04-21 12:11:08 EDT 
Build Identifier: 

After throwing the socket exception, such as the listen port is used up, 
scid does not handle it correctly. 
Update the scid to catch this exception, and do the error handling.

Reproducible: Always
Comment 1 rong li CLA 2011-04-21 12:15:14 EDT 
Created attachment 193857 [details]
Submit the patch for updating the error handling of scid

Submit the patch for updating the error handling of scid
Comment 2 Tu Hong Jun CLA 2011-04-21 22:26:18 EDT 
Could you change the code from exit(1) to exit(-1) to comply with the existing coding style?
Comment 3 Tu Hong Jun CLA 2011-04-22 01:08:21 EDT 
I have applied the patch with the change I mentioned.
Comment 4 rong li CLA 2011-04-22 04:36:54 EDT 
Thanks for your comments. In the current source codes, scia.cpp uses "exit(1)" instead of "exit(-1)". We can change it to "exit(-1)" to make all the existing coding style consistent.
Comment 5 rong li CLA 2012-11-06 05:07:15 EST 
The codes have already been committed into the branch.