Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343554 - ICU4J violations
Summary: ICU4J violations
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Main (show other bugs)
Version: 0.9.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.9.0 M7   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-21 10:33 EDT by Nicolas Bros CLA
Modified: 2011-08-18 08:16 EDT (History)
3 users (show)

See Also:
nicolas.bros: indigo+

Attachments
violations (2.92 KB, text/plain)
2011-04-21 10:33 EDT, Nicolas Bros CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2011-04-21 10:33:28 EDT 
Created attachment 193833 [details]
violations

I used the tool I just made (Bug 343533) to check for violations to the ICU4J rule related to the simultaneous release requirements (http://wiki.eclipse.org/ICU4J).

It reports 21 violations in MoDisco code (see attached report).
Comment 1 Nicolas Bros CLA 2011-04-29 03:47:29 EDT 
I committed fixes in revision 4366.

But there are still these remaining occurrences I'm not sure about:

java.lang.Character : /org.eclipse.gmt.modisco.java.discoverer/src/org/eclipse/gmt/modisco/java/io/library/ClassFileParser.java
java.lang.Character : /org.eclipse.gmt.modisco.java.discoverer/src/org/eclipse/gmt/modisco/java/io/library/ClassFileParser.java
java.lang.Character : /org.eclipse.modisco.java.discoverer/src/org/eclipse/modisco/java/discoverer/internal/io/library/ClassFileParser.java
java.lang.Character : /org.eclipse.modisco.java.discoverer/src/org/eclipse/modisco/java/discoverer/internal/io/library/ClassFileParser.java
Comment 2 Fabien Giquel CLA 2011-04-29 04:09:01 EDT 
Hi Nicolas,

org.eclipse.jdt.core API is used in ClassFileParser.java
org.eclipse.jdt.core published API uses java.lang.Character (see IMemberValuePair.K_CHAR). We cannot use icu4j UCharacter using this API.

It will be an exception to the ICU4J requirement.
Comment 3 Nicolas Bros CLA 2011-04-29 04:36:10 EDT 
Thanks for your confirmation. I'm marking this bug as fixed.
Comment 4 Hugo Bruneliere CLA 2011-08-18 08:16:13 EDT 
Bug solved.