Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343533 - [Dev] Tool to check non-ICU4J references
Summary: [Dev] Tool to check non-ICU4J references
Status: REOPENED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P5 trivial (vote)
Target Milestone: ---   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-21 09:53 EDT by Nicolas Bros CLA
Modified: 2020-05-01 11:26 EDT (History)
2 users (show)

See Also:
nicolas.bros: indigo+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2011-04-21 09:53:20 EDT 
One of the requirements from the simultaneous release is that "Projects must use ICU4J, where appropriate, to excel in NL support." (see http://wiki.eclipse.org/ICU4J for the exact rules)

So, we must check that we are not using any forbidden types, preferably with a suitable tool.
Comment 1 Nicolas Bros CLA 2011-04-21 09:55:58 EDT 
I committed one such tool in revision 557.
It uses the JDT Search API to find occurrences of the forbidden types in the workspace:
/org.eclipse.emf.facet.dev.core/src/org/eclipse/emf/facet/dev/core/CheckICU4JHandler.java
Comment 2 Nicolas Bros CLA 2011-04-21 10:11:02 EDT 
I worked well in my runtime workspace, but when I tried to run it on my main workspace, I got a lot of false positives from referenced libraries. Reopening.
Comment 3 Nicolas Bros CLA 2011-04-21 10:40:07 EDT 
I got rid of the false positives by filtering out binary members.
Committed in revision 558.
Comment 4 Nicolas Bros CLA 2011-04-22 10:55:01 EDT 
Note: the wording I used in my previous comment wasn't clear ("I committed one such tool"). So, I wanted to make it clear that this is a tool I wrote myself, and there is no need for an IP review.
Comment 5 Gregoire Dupe CLA 2011-06-08 10:49:19 EDT 
Hello Nicolas,

Is this tool launched during each build and provide a report?

Regards,
Gregoire
Comment 6 Nicolas Bros CLA 2011-06-08 11:19:21 EDT 
(In reply to comment #5)
> Hello Nicolas,
> 
> Is this tool launched during each build and provide a report?

No, it must be launched manually from a workspace containing the plug-ins to check. I don't think it is possible to run it during the build.
Comment 7 Gregoire Dupe CLA 2011-06-08 11:28:13 EDT 
(In reply to comment #6)
> (In reply to comment #5)
> > Hello Nicolas,
> > 
> > Is this tool launched during each build and provide a report?
> 
> No, it must be launched manually from a workspace containing the plug-ins to
> check. I don't think it is possible to run it during the build.

Ok, I reopen this bug because such tools have to be launched during each build to be relevant.

Here is some ideas:
 - use MoDisco (n-1 version to avoid cyclic dependencies),
 - use text search.

Regards,
Gregoire Dupe