Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343443 - org.eclipse.mylyn.versions-feature is missing dependendies in feature.xml
Summary: org.eclipse.mylyn.versions-feature is missing dependendies in feature.xml
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 0.7.1   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-20 13:49 EDT by Severin Gehwolf CLA
Modified: 2011-04-20 15:31 EDT (History)
0 users

See Also:

Attachments
Proposed patch. (845 bytes, patch)
2011-04-20 13:51 EDT, Severin Gehwolf CLA 		no flags Details | Diff
committed patch (1.79 KB, patch)
2011-04-20 15:03 EDT, Steffen Pingel CLA 		no flags Details | Diff
mylyn/context/zip (2.77 KB, application/octet-stream)
2011-04-20 15:04 EDT, Steffen Pingel CLA 		no flags Details
forward ported patch (1.66 KB, patch)
2011-04-20 15:17 EDT, Steffen Pingel CLA 		no flags Details | Diff
mylyn/context/zip (2.40 KB, application/octet-stream)
2011-04-20 15:17 EDT, Steffen Pingel CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Severin Gehwolf CLA 2011-04-20 13:49:21 EDT 
Feature org.eclipse.mylyn.versions is missing some dependencies without them it can't be built. I encountered this problem while working on RPMs for Fedora.

- org.eclipse.mylyn.commons.core
- org.eclipse.mylyn.team.ui (which in turn has org.eclipse.mylyn_veature as a dependency)
Comment 1 Severin Gehwolf CLA 2011-04-20 13:51:22 EDT 
Created attachment 193729 [details]
Proposed patch.

Explicitly list dependencies in feature.xml
Comment 2 Steffen Pingel CLA 2011-04-20 14:32:04 EDT 
Hmm, the Versions feature must not depend on org.eclipse.mylyn_feature or org.eclipse.mylyn.team.ui and there should also be no reverse dependency.

I am happy to add the requirement on org.eclipse.mylyn.commons.core but it that going to fix the build problem for you?
Comment 3 Severin Gehwolf CLA 2011-04-20 14:55:24 EDT 
There is a Require-Bundle:  org.eclipse.mylyn.team.ui in org.eclipse.mylyn.versions.ui (which org.eclipse.mylyn.versions feature builds) Thoughts?
Comment 4 Steffen Pingel CLA 2011-04-20 15:03:37 EDT 
Created attachment 193740 [details]
committed patch
Comment 5 Steffen Pingel CLA 2011-04-20 15:04:57 EDT 
That is indeed a mistake. I have removed the bogus dependency on org.eclipse.mylyn.team.ui and added the org.eclipse.mylyn.commons.core dependency for the feature.
Comment 6 Steffen Pingel CLA 2011-04-20 15:04:59 EDT 
Created attachment 193741 [details]
mylyn/context/zip
Comment 7 Steffen Pingel CLA 2011-04-20 15:17:09 EDT 
Created attachment 193743 [details]
forward ported patch
Comment 8 Steffen Pingel CLA 2011-04-20 15:17:11 EDT 
Created attachment 193744 [details]
mylyn/context/zip
Comment 9 Steffen Pingel CLA 2011-04-20 15:18:15 EDT 
I have committed the fix to the e_3_7_m_3_5_x branch and head. Severin, please let me know in case that does not resolve the problem you were experiencing.
Comment 10 Severin Gehwolf CLA 2011-04-20 15:31:06 EDT 
It builds fine now. Nice, less deps :)