Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343412 - [server][git] Repository is created even if cloning fails
Summary: [server][git] Repository is created even if cloning fails
Status: VERIFIED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-20 09:54 EDT by Malgorzata Janczarska CLA
Modified: 2011-09-01 11:41 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Malgorzata Janczarska CLA 2011-04-20 09:54:32 EDT 
1. Start cloning action with input data that will fail, for instance
	* invalid uri
	* invalid credentials
2. Cloning fails
3. The repository is shown in result of GET /git/clone
4. Under content location a there is a directory wit ".git" subdirectory and some git metadata

Expected:
after failure of git clone operation all the changes should be rolled back. The repository that could not be cloned shouldn't be shown in GET /git/clone list and the directory should be removed as well, as the user who triggered cloning operation doesn't have access to server filesystem.
Comment 1 Tomasz Zarna CLA 2011-04-22 03:06:42 EDT 
(In reply to comment #0)
> 1. Start cloning action with input data that will fail, for instance
> * invalid uri
> * invalid credentials
> 2. Cloning fails
> 3. The repository is shown in result of GET /git/clone

This is already covered by bug 343408.

> 4. Under content location a there is a directory wit ".git" subdirectory and
> some git metadata

I haven't checked it but this is strange. How can "git clone" create any local resources with the URI or credentials are bad? I will take a look... but can't promise it for M7.
Comment 2 Tomasz Zarna CLA 2011-04-22 07:13:02 EDT 
Fixed with http://git.eclipse.org/c/e4/org.eclipse.orion.server.git/commit/?id=8e49b653f93b15695c7b5f69ad9490455cf6d93f. In case of an error CloneJob now cleans up after itself.