Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343383 - Move RWTLifeCycle#getSessionDisplay() to a utility class
Summary: Move RWTLifeCycle#getSessionDisplay() to a utility class
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.4 M7   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 341763
  Show dependency tree
 
Reported: 2011-04-20 07:36 EDT by Rüdiger Herrmann CLA
Modified: 2011-04-20 08:33 EDT (History)
0 users

See Also:


Attachments
Fix (238 bytes, patch)
2011-04-20 07:46 EDT, Rüdiger Herrmann CLA
no flags Details | Diff
Proper fix (35.21 KB, patch)
2011-04-20 08:31 EDT, Rüdiger Herrmann CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rüdiger Herrmann CLA 2011-04-20 07:36:26 EDT
The RWTLifeCycle has methods to get and set the _session display_. In contrast to Display#getCurent(), getSessionDisplay() returns the display even if it was disposed of.
As these methods are not specific to the RWTLifeCycle, they should be moved to a 'neutral' place.
Comment 1 Rüdiger Herrmann CLA 2011-04-20 07:46:47 EDT
Created attachment 193686 [details]
Fix

Created a LifeCycleUtil class that provides getSessionDisplay() and setSessionDisplay().
In addition, getEntryPoint() was also moved to the new class, its functionality is used by RWTLifeCycle and ProcessAction.
Comment 2 Rüdiger Herrmann CLA 2011-04-20 08:31:17 EDT
Created attachment 193688 [details]
Proper fix

The first patch contains bogus data, recreated patch. 
For a description of the changes see comment #1 .
Comment 3 Rüdiger Herrmann CLA 2011-04-20 08:33:20 EDT
Applied patch to CVS HEAD.