Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343310 - [mojo] build-helper-maven-plugin add-resource and add-test-resource goals
Summary: [mojo] build-helper-maven-plugin add-resource and add-test-resource goals
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: m2e (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 343030 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-04-19 15:46 EDT by Igor Fedorenko CLA
Modified: 2021-04-19 13:25 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Fedorenko CLA 2011-04-19 15:46:06 EDT
It would be nice if build-helper-maven-plugin configurator supported  add-resource and add-test-resource goals.
Comment 1 Mark A. Ziesemer CLA 2011-04-19 19:26:43 EDT
(See also, bug 343030.)
Comment 2 Igor Fedorenko CLA 2011-06-27 01:32:05 EDT
*** Bug 343030 has been marked as a duplicate of this bug. ***
Comment 3 Igor Fedorenko CLA 2011-06-29 02:13:12 EDT
m2e core development team is looking for help implementing support for various "not covered" maven plugins. If you are interested, wiki [1] provides pointers where to start and we'll be happy to answer questions on m2e-dev mailing list. To avoid duplicate effort, please assign this bugzilla item to yourself if you already work on corresponding m2e extension.

[1] m2e extension development is documented in http://wiki.eclipse.org/M2E_Extension_Development
Comment 4 Phillip Webb CLA 2011-07-05 10:43:45 EDT
Hi Igor,

I would like to have a look at fixing this but I am having trouble importing https://github.com/sonatype/m2eclipse-extras into eclipse.  Are there any instructions available?
Comment 5 Igor Fedorenko CLA 2011-07-05 16:53:37 EDT
m2e extensions development environment setup is documented in [1]. After that, import m2eclipse-extras as existing Maven project and let m2e install additional software when asked and let m2e restart workspace after that. All projects should compile clean when Eclipse comes back from restart.


[1] http://wiki.eclipse.org/M2E_extension_development_environment
Comment 6 Phillip Webb CLA 2011-07-06 07:38:50 EDT
Thanks for the link, I have everything imported now.  

Do you have an eclipse code formatter settings file anywhere?  I would like to make sure anything I do follows your conventions.
Comment 7 Igor Fedorenko CLA 2011-07-06 09:14:50 EDT
http://maven.apache.org/developers/maven-eclipse-codestyle.xml

also, beware that m2eclipse-extras is not part of m2e eclipse project and Sonatype requires signed CLA before accepting any code contributions to that codebase. http://www.sonatype.org/SonatypeCLA.pdf
Comment 8 Phillip Webb CLA 2011-09-13 09:49:36 EDT
Hi Igor,

I have added support for the add-resource and add-test-resource goals here:
https://github.com/SciSysUK/m2eclipse-extras/tree/bug343310

I have also fixed a bug where tests class were output to the wrong directory.

Could you let me know if the contribution would be accepted before I complete the CLA.  Also the CLA link is the "Individual Contributor Agreement", is there a link for the "Corporate Contributor Agreement"?

Cheers,
Phil.
Comment 9 Igor Fedorenko CLA 2011-09-13 12:18:59 EDT
(In reply to comment #8)
> Hi Igor,
> 
> I have added support for the add-resource and add-test-resource goals here:
> https://github.com/SciSysUK/m2eclipse-extras/tree/bug343310
> 
> I have also fixed a bug where tests class were output to the wrong directory.

I was going to merge https://github.com/sonatype/m2eclipse-extras/pull/6 later today or tomorrow, which appears to be solving the same problem.

> 
> Could you let me know if the contribution would be accepted before I complete
> the CLA.  Also the CLA link is the "Individual Contributor Agreement", is there
> a link for the "Corporate Contributor Agreement"?
> 

Please email this question to community@sonatype.com
Comment 10 Phillip Webb CLA 2011-09-13 12:32:19 EDT
Typical, I should not have taken so long to get around to it I guess.  I might be worth comparing the solutions as I think that mine does not have the issue of the wrong output directory.  I will put a comment on Gekkio's pull request so that he is also aware of it.
Comment 11 Igor Fedorenko CLA 2011-09-28 22:59:12 EDT
Done. Thank you for your contribution and patience.
Comment 12 Denis Roy CLA 2021-04-19 13:25:25 EDT
Moved to https://github.com/eclipse-m2e/m2e-core/issues/