Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343273 - [Compatibility] Quick Access dialog opens on wrong monitor
Summary: [Compatibility] Quick Access dialog opens on wrong monitor
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.1 RC3   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-19 10:32 EDT by Andrew Niefer CLA
Modified: 2011-05-27 08:19 EDT (History)
2 users (show)

See Also:

Attachments
screenshot (1.12 MB, image/png)
2011-04-19 10:32 EDT, Andrew Niefer CLA 		no flags Details
SearchField patch v1 (2.79 KB, patch)
2011-05-20 09:31 EDT, Remy Suen CLA 		no flags Details | Diff
SearchField patch v2 (2.43 KB, patch)
2011-05-25 14:41 EDT, Remy Suen CLA 		no flags Details | Diff
SearchField patch v03 (4.22 KB, patch)
2011-05-27 08:08 EDT, Paul Webster CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Niefer CLA 2011-04-19 10:32:57 EDT 
Created attachment 193585 [details]
screenshot

Running on Linux with two monitors, and Eclipse on the second monitor, 
when I use the quick access dialog, it appears on the primary monitor instead.

See attached screenshot.
Comment 1 Remy Suen CLA 2011-05-20 09:31:27 EDT 
Created attachment 196216 [details]
SearchField patch v1

Instead of relying on getMonitor() I'm opting to just iterate over all the monitors returned by the display. I'm hoping this will do the trick.
Comment 2 Remy Suen CLA 2011-05-25 14:41:31 EDT 
Created attachment 196594 [details]
SearchField patch v2

Fallback to the original code if the loop checking is not satisfied.
Comment 3 Remy Suen CLA 2011-05-25 14:42:12 EDT 
(In reply to comment #2)
> Created attachment 196594 [details]
> SearchField patch v2

Patch released to CVS HEAD, let's see how it goes...
Comment 4 Paul Webster CLA 2011-05-27 08:08:07 EDT 
Created attachment 196747 [details]
SearchField patch v03

This takes the same approach as JFace window.

PW
Comment 5 Remy Suen CLA 2011-05-27 08:19:29 EDT 
(In reply to comment #4)
> Created attachment 196747 [details]
> SearchField patch v03

Looks good, thanks Paul. I've released this patch with javadoc additions to note where we copy/pasted those methods from.