Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343266 - equinox.p2.user.ui feature is not properly generating nested source features
Summary: equinox.p2.user.ui feature is not properly generating nested source features
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M7   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 343711 (view as bug list)
Depends on:
Blocks: 342829
  Show dependency tree
 
Reported: 2011-04-19 09:43 EDT by Kim Moir CLA
Modified: 2011-04-27 15:10 EDT (History)
5 users (show)

See Also:

Attachments
patch - source feature wisdom of Andrew (4.37 KB, patch)
2011-04-26 15:29 EDT, Kim Moir CLA 		no flags Details | Diff
patch (1.29 KB, patch)
2011-04-27 09:51 EDT, Kim Moir CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kim Moir CLA 2011-04-19 09:43:16 EDT 
The equinox.p2.user.ui feature was reorganized a while ago in bug 333810.  Since then, the nested features in the org.eclipse.equinox.p2.user.ui feature are not generating source features.  I ran a several test builds yesterday to try to solve this problem but to no avail.  I also noticed that the way that this feature is organized is rather strange

p2.user.ui feature includes p2.core, p2.extras and p2.rcp features

but p2.extras and p2.rcp both include the p2.core feature as a nested feature

The reason that this is causing a problem is that the p2 source bundles are being generated but not included in the SDK feature.  Thus code coverage reports fail because the p2.source bundles aren't included in the the SDK.  We need the source bundles to run the tool.  

Please fix the p2.user.ui feature so that the p2.core, p2.extras and p2.rcp source features are generated.
Comment 1 Kim Moir CLA 2011-04-24 16:59:46 EDT 
*** Bug 343711 has been marked as a duplicate of this bug. ***
Comment 2 Pascal Rapicault CLA 2011-04-25 15:08:48 EDT 
We talked about it during p2 call. DJ will seek guidance on how to solve this.
Comment 3 DJ Houghton CLA 2011-04-26 09:58:07 EDT 
Andrew, do you have hints on what the feature structure needs to look like?
Comment 4 Kim Moir CLA 2011-04-26 15:29:44 EDT 
Created attachment 194094 [details]
patch - source feature wisdom of Andrew
Comment 5 DJ Houghton CLA 2011-04-26 16:29:22 EDT 
Kim, this patch doesn't cleanly apply in my workspace (platform-feature). Also I will find out for sure when I try and commit it, but I'm not sure if we have commit rights to the platform feature.
Comment 6 Kim Moir CLA 2011-04-26 16:34:29 EDT 
DJ, I have already applied the patch and ran a test build which failed.  Trying to figure out why it is failing.

As an aside, whoever is tagging for p2 tonight, please don't tag these p2 features.  I may have to revert...
Comment 7 Kim Moir CLA 2011-04-26 16:58:13 EDT 
As an aside, here is the test build with the problem

http://eclipsebuildserv.ottawa.ibm.com/downloads/bogus/downloads/drops/N20110426-1532/index.php
Comment 8 Kim Moir CLA 2011-04-27 09:51:21 EDT 
Created attachment 194155 [details]
patch
Comment 9 Kim Moir CLA 2011-04-27 12:46:13 EDT 
Tagged for i-build.
Comment 10 Kim Moir CLA 2011-04-27 15:10:20 EDT 
Verified that p2* source features are generated properly in I20110427-1300.