343247 – [server] Git Commit operation returns empty response

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343247 - [server] Git Commit operation returns empty response

Summary: [server] Git Commit operation returns empty response

Status:	RESOLVED FIXED

Alias:	None

Product:	Orion
Classification:	ECD
Component:	Git (show other bugs)
Version:	0.2
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	0.2
Assignee:	Szymon Brandys
QA Contact:

URL:
Whiteboard:	gsoc2011
Keywords:

Depends on:
Blocks:

Reported:	2011-04-19 05:02 EDT by Szymon Brandys
Modified:	2012-01-19 10:59 EST (History)
CC List:	3 users (show)

See Also:

Flags:	Szymon.Brandys: review+ tomasz.zarna: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Szymon Brandys

2011-04-19 05:02:17 EDT

When changes are committed using POST /git/commit/HEAD.... the response is just 200. I would expect to see more details in the response, at least:
- the commit location
- the commit name

Comment 1 Simon Kaegi

2011-06-09 11:17:11 EDT

Szymon, not sure who to assign this too. Marked for RC1 right now so want an owner.

Comment 2 Piotr Janik

2011-06-09 12:25:24 EDT

My proposal: https://github.com/pjanik/orion.server/tree/bug343247

I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use.

In my fix, response contains the same information which is returned during log operation (GET /gitapi/commit...) - name, location, message etc.

Comment 3 Tomasz Zarna

2011-06-13 10:33:25 EDT

https://github.com/pjanik/orion.server/commit/06ac21df741b6b45084e701633b1fa0e1190d744 looks good.

Comment 4 Szymon Brandys

2011-06-13 10:35:20 EDT

Fixed with 1bc9254ef2a3bb989b5726377b2bb96257ab345d.