Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343225 - [NLS] Clean up LogValStart and LogValEnd strings
Summary: [NLS] Clean up LogValStart and LogValEnd strings
Status: RESOLVED FIXED
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: wst.validation (show other bugs)
Version: 3.2.3   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Nitin Dahyabhai CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-18 22:25 EDT by Nitin Dahyabhai CLA
Modified: 2011-04-28 22:10 EDT (History)
2 users (show)

See Also:
david_williams: pmc_approved+
thatnitind: pmc_approved? (raghunathan.srinivasan)
thatnitind: pmc_approved? (naci.dai)
thatnitind: pmc_approved? (deboer)
thatnitind: pmc_approved? (neil.hauge)
thatnitind: pmc_approved? (kaloyan)
thatnitind: pmc_approved? (cbridgha)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nitin Dahyabhai CLA 2011-04-18 22:25:03 EDT 
Currently the LogValStart string, for example, is "Validator {0} starting to validate: {1}" which, since we name our validators "XYZ Validator", results in "Validator XYZ Validator starting to validate:" {1}.  That would look better without the leading word.
Comment 1 Nitin Dahyabhai CLA 2011-04-20 23:24:28 EDT 
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

The wording with all of our validators named "XYZ Validator" is amatuerish.

* Is there a work-around? If so, why do you believe the work-around is insufficient? 

No workaround.  Removing "Validator" from our validator names wouldn't improve things, and would be a larger change.

* How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

Ad-hoc.

* Give a brief technical overview. Who has reviewed this fix? 
Changes to values in properties files.  Binding placeholders remain.

* What is the risk associated with this fix?

None, but mea culpa, I forgot to get it approved before I checked it in and released it two days ago.
Comment 2 Nitin Dahyabhai CLA 2011-04-21 00:08:59 EDT 
Changed.