Community
Participate
Working Groups
Build Identifier: 0.7.3 The activity diagram plug-in makes two paletteProvider contributions. One of these contributions does not limit its scope to the activity diagram editor. This causes side effects on all other GMF based diagram editors. Moreover some local icons are not resolved in this paletteProvider... Reproducible: Always
Created attachment 193485 [details] A patch to fix this issue
Hello, we can not reproduce the bug "This causes side effects on all other GMF based diagram editors." having no adequate other GMF editor in our environment. We will make the correction anyway, but can you tell us which editor you have encountered the bug with and the exact steps to reproduce it ? If, after that, we still can not reproduce (environment too complex to reproduce for us), maybe I will ask you to test our fix to make sure the bug is not reproduced. Thanks in advance.
The part about images has been corrected. The editor id in the paletteProvider can not be easily added because these extensions are generated. Hence, the problem is not limited to the activity diagram, but actually to the Papyrus diagram generation. Could you try and tell us if you can reproduce the same problem with Class diagram for example ? (and how you reproduce it)
(In reply to comment #3) > The part about images has been corrected. > > The editor id in the paletteProvider can not be easily added because these > extensions are generated. > Hence, the problem is not limited to the activity diagram, but actually to the > Papyrus diagram generation. > > Could you try and tell us if you can reproduce the same problem with Class > diagram for example ? (and how you reproduce it) I agree with you that the same kind of problem can occur with other Papyrus plug-ins. I think this only depends on the contribution order of the different Papyrus providers. Actually Remi has already fixed this kind of issue in the common plugin: https://bugs.eclipse.org/bugs/show_bug.cgi?id=341897
(In reply to comment #4) > I agree with you that the same kind of problem can occur with other Papyrus > plug-ins. I think this only depends on the contribution order of the different > Papyrus providers. > Actually Remi has already fixed this kind of issue in the common plugin: > https://bugs.eclipse.org/bugs/show_bug.cgi?id=341897 The part that Remi has fixed is not generated. Only diagrams plugins are. If as you suggest, the contribution order has an impact, this means the first contribution only is taken in account, as they must have similar ids. Hence, the bug will still occur as long as there is at least one contribution. I think we should modify the Papyrus generators to fix this issue. But as I haven't reproduced this issue, that would help me if you can tell me all the steps you have performed to reproduce the bug : - which other gmf editor you used ? - which actions you have performed in this editor ? - which palette tools pollute your editor ?
(In reply to comment #5) > (In reply to comment #4) > > I agree with you that the same kind of problem can occur with other Papyrus > > plug-ins. I think this only depends on the contribution order of the different > > Papyrus providers. > > Actually Remi has already fixed this kind of issue in the common plugin: > > https://bugs.eclipse.org/bugs/show_bug.cgi?id=341897 > > The part that Remi has fixed is not generated. Only diagrams plugins are. > > If as you suggest, the contribution order has an impact, this means the first > contribution only is taken in account, as they must have similar ids. Hence, > the bug will still occur as long as there is at least one contribution. > > I think we should modify the Papyrus generators to fix this issue. But as I > haven't reproduced this issue, that would help me if you can tell me all the > steps you have performed to reproduce the bug : > - which other gmf editor you used ? We reproduce with our GMF runtime based editor, to reproduce simply takes another GMF editor (for instance the logic example), and modify its palette provider priority to be lower than this one. > - which actions you have performed in this editor ? No actions is necessary. > - which palette tools pollute your editor ? You will remove note and note attachments to all editors. This removal should be strictly limited to your editor id ! The entries you provide after will not be contributed because there are only predefined (see "defineOnly="true"). See http://help.eclipse.org/helios/index.jsp?topic=/org.eclipse.gmf.doc/tutorials/diagram/paletteConfigurationTutorial.html for more information
I see this task is still marked as "Critical", but it seems there where no news from some time now. Is it fixed?
We are unable to reproduce this bug at this point. So we are closing the bug.
