Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343141 - [Markers] Problems view: State lost after checking "Show all items" and clicking OK
Summary: [Markers] Problems view: State lost after checking "Show all items" and click...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.7 M7   Edit
Assignee: Prakash Rangaraj CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-18 08:14 EDT by Markus Keller CLA
Modified: 2011-04-27 12:28 EDT (History)
1 user (show)

See Also:

Attachments
Patch v01 (2.33 KB, patch)
2011-04-25 03:58 EDT, Prakash Rangaraj CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-04-18 08:14:13 EDT 
N20110417-2000

Problems view > Configure Contents...:
- toggle "Show all items"
 => state of configuration check boxes is restored when "Show all items" is unchecked
- check "Show all items"
- click OK
- reopen dialog
- uncheck "Show all items"
 => just the first configuration is checked
 => expected: should restore the previous selection
Comment 1 Dani Megert CLA 2011-04-18 10:50:30 EDT 
Prakash, it would be good to preserve the state.
Comment 2 Prakash Rangaraj CLA 2011-04-25 03:58:42 EDT 
Created attachment 193980 [details]
Patch v01
Comment 3 Prakash Rangaraj CLA 2011-04-25 04:09:44 EDT 
Patch v01 released to HEAD
Comment 4 Prakash Rangaraj CLA 2011-04-25 04:11:23 EDT 
(In reply to comment #3)
> Patch v01 released to HEAD
Comment 5 Markus Keller CLA 2011-04-25 12:21:06 EDT 
Comment on attachment 193980 [details]
Patch v01

Thanks, looks good.

The actual fix went to HEAD of FiltersConfigurationDialog (not the attached Patch v01).
Comment 6 Dani Megert CLA 2011-04-26 05:53:09 EDT 
The dialog looks good, but I think we should also synchronize the view menu selection: currently if I switch from 'Show All' to filter 'A', then select 'Show All' again and then open the dialog, it will show the last state it had in the dialog (instead of the view menu) when I deselect 'Show all items'.
Comment 7 Prakash Rangaraj CLA 2011-04-27 02:30:06 EDT 
Verified in I20110425-1800
Comment 8 Dani Megert CLA 2011-04-27 12:28:02 EDT 
(In reply to comment #6)
> The dialog looks good, but I think we should also synchronize the view menu
> selection: currently if I switch from 'Show All' to filter 'A', then select
> 'Show All' again and then open the dialog, it will show the last state it had
> in the dialog (instead of the view menu) when I deselect 'Show all items'.

Filed bug 343988 to track this.