Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343080 - Handle invalid ServiceHandler id parameter
Summary: Handle invalid ServiceHandler id parameter
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.4   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 1.5 M6   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-17 17:46 EDT by Ralf Sternberg CLA
Modified: 2012-03-14 19:23 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Sternberg CLA 2011-04-17 17:46:10 EDT 
When the server receives a request for a service handler that has not been registered, it silently answers with the initial HTML page. This can make it hard to track down a problem caused by a misspelled service handler id.

I think we should throw an exception when the parameter "custom_service_handler" is present in a request but has an invalid value.
Comment 1 Rüdiger Herrmann CLA 2011-04-18 03:41:23 EDT 
+1 for throwing an exception
Comment 2 Ralf Sternberg CLA 2012-03-14 19:23:14 EDT 
Now an InvalidArgumentException is thrown in ServiceManager in case of an invalid service handler id, leading to an HTTP 500. This is an inappropriate response code (see also bug 371935), but at least the error gets noticed. I opened bug 374327 for registering service handlers by path as well.

Changes are in CVS HEAD.