Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343034 - ModelServiceImpl should use EMF-API to iterate
Summary: ModelServiceImpl should use EMF-API to iterate
Status: RESOLVED WORKSFORME
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-16 07:32 EDT by Thomas Schindl CLA
Modified: 2019-06-05 07:26 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schindl CLA 2011-04-16 07:32:35 EDT
The iteration to find certain things in the model is done by consulting our own API but it would be much better to use EMF-API because in case of model evolution and extension we can't be sure we are really traversing the complete model

The best way would be to use "EcoreUtil.getAllContents(eObject, resolve)" which returns an iterator to traverse all containment elements. All we need to add is the logic to go deeper when we traverse an MPlaceholder.
Comment 1 Thomas Schindl CLA 2011-04-16 07:34:11 EDT
an example how dangerous the current implementation is the newly introduced countRenderableChildren which doesn't take detached windows into consideration.
Comment 2 Eclipse Genie CLA 2018-11-06 11:44:33 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 3 Lars Vogel CLA 2019-06-05 07:26:48 EDT
This is a mass change to close all e4 bugs marked with "stalebug" whiteboard.

If this bug is still valid, please reopen and remove the "stalebug" keyword.