Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 343010 - [region] need for location munging when calling Region.installBundle
Summary: [region] need for location munging when calling Region.installBundle
Status: RESOLVED WONTFIX
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Components (show other bugs)
Version: 3.7   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: equinox.components-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-15 15:15 EDT by Thomas Watson CLA
Modified: 2011-05-24 04:43 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Watson CLA 2011-04-15 15:15:06 EDT
In BundleIdBasedRegion.installBundle methods the region name is prepended to the passed in location string.  This seems unnecessary and forces a transformed location onto the caller with a built in policy to include the region name in the location string.

On one hand this seems like a good thing because it helps create unique location strings for cases where the same bundle is installed in multiple regions.  On the other hand it forces a location string format on to the caller.  I don't have a great suggestion for how to do something different here.  Simply opening this bug to discuss.

The javadoc currently does state that the region name is prepended to the given location.  At a minimum the javadoc should state the format of the prepended region name (e.g. a '@' char is used to separate the region name from the location).
Comment 1 Glyn Normington CLA 2011-04-15 16:50:06 EDT
Why would any bundle care about the location used to install it? Is there some usage pattern I'm missing?
Comment 2 Thomas Watson CLA 2011-04-15 17:03:04 EDT
(In reply to comment #1)
> Why would any bundle care about the location used to install it? Is there some
> usage pattern I'm missing?

Well, the current configuration admin spec is dependent on the bundle location used to install a bundle, if we change that under the covers it may surprise some provisioning agents that also configure using configuration Admin.
Comment 3 Thomas Watson CLA 2011-05-20 09:55:42 EDT
Closing as wontfix for now.  I think the benefits of ensuring unique locations are important and what we do is fine for now.
Comment 4 Glyn Normington CLA 2011-05-24 04:43:36 EDT
Fine. Note that another method of making the location unique across regions was discussed in https://bugs.eclipse.org/bugs/show_bug.cgi?id=346127#c8, but this would still presumably impact Config Admin uses cases as mentioned in Comment 2.