Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342978 - Refactor Tree widget to make it really virtual
Summary: Refactor Tree widget to make it really virtual
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.5 M1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard: plan-version=1.5 plan-theme=widgets p...
Keywords:
Depends on:
Blocks: 332524 336169
  Show dependency tree
 
Reported: 2011-04-15 10:09 EDT by Ivan Furnadjiev CLA
Modified: 2011-08-25 12:03 EDT (History)
1 user (show)

See Also:

Attachments
Server-side refactoring (61.65 KB, patch)
2011-05-13 10:59 EDT, Ivan Furnadjiev CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Furnadjiev CLA 2011-04-15 10:09:53 EDT 
Currently the virtual Tree widget is not really virtual. When the Tree#setItemCounts is called the TreeItem objects are created regardless the Tree is VIRTUAL or not.
Comment 1 Tim Buschtoens CLA 2011-05-06 14:16:02 EDT 
Added implementation for setItemCount to TreeItem.js and Tree.js in CVS HEAD.
Comment 2 Ivan Furnadjiev CLA 2011-05-13 10:57:22 EDT 
We did some refactoring on the server-side Tree as well. There are still some room for improvements like:
* Tree#setItemCount should not create items if tree is virtual.
* not use public methods like getItem( int ), getItems(), getItemCount() internally to avoid items creation
* rework getTopItem(), should not call collectVisibleItems (Performance)
* clean up collectVisibleItems
* improve flatIndices updating
Changes are in CVS HEAD.
Comment 3 Ivan Furnadjiev CLA 2011-05-13 10:59:50 EDT 
Created attachment 195597 [details]
Server-side refactoring
Comment 4 Ivan Furnadjiev CLA 2011-08-08 05:19:45 EDT 
All needed refactorings related to virtual behavior of the Tree are in CVS HEAD.