Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342965 - [client]git log : use /diffURI?readonly=true when comparing 2 commits.
Summary: [client]git log : use /diffURI?readonly=true when comparing 2 commits.
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Szymon Brandys CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-15 09:08 EDT by libing wang CLA
Modified: 2011-09-01 11:43 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description libing wang CLA 2011-04-15 09:08:22 EDT 
please use diffURI + "?readonly=true"  when comparing 2 commits from git log.
This will disable the editing on left side.
Comment 1 Szymon Brandys CLA 2011-04-15 09:18:36 EDT 
So, should it be 
compare.html?readonly=true#diffURI
or
compare.html#diffURI?readonly=true
?

I think that the first on is the right one.
Comment 2 Szymon Brandys CLA 2011-04-15 09:46:05 EDT 
Fixed.
According to Libing we use compare.html#diffURI?readonly=true at this point. He is going to refactor the URIs once he switches to compare.html?readonly=true#diffURI.
Comment 3 libing wang CLA 2011-04-15 10:46:47 EDT 
(In reply to comment #2)
> Fixed.
> According to Libing we use compare.html#diffURI?readonly=true at this point. He
> is going to refactor the URIs once he switches to
> compare.html?readonly=true#diffURI.

refactored compare-m.html#diffURI?readonly=true to comapre-m.html?readonly#difURI