Community
Participate
Working Groups
Build Identifier: 20110319-2305 having added the MinMaxAddon I would suspect a "Maximize"-Button to appear for a PartStack. At the moment I only have the Minimize-Button. Double-Clicking the Header also does not lead to maximizing the part. Using 0.9.1.v20110331-2030 of the org.eclipse.e4.ui.workbench and *.renderers.swt plug-ins for a simple e4 RCP Application (see attached project). Reproducible: Always Steps to Reproduce: Please refer to the attached test project.
Created attachment 193350 [details] testcase project
Do you see the adjustCTFButtons(MUIElement) method of the MinMaxAddon getting called?
org.eclipse.e4.ui.workbench.addons.minmax.MinMaxAddon does not have a method named adjustCTFButtons. Actually: I didn't find any function with that name in any of the plug-ins of my Target Platform. Using Plugin: org.eclipse.e4.ui.workbench.addons.swt (0.9.0.v20110311-1500)
(In reply to comment #3) > Using Plugin: org.eclipse.e4.ui.workbench.addons.swt (0.9.0.v20110311-1500) You need a newer bundle then.
so this isn't actually a bug. Sorry for that. Closing the issue ... I would have suspected the newer plug-in to be included in one of the Stream Integration Builds (i.e. eclipse-e4-repo-incubation-I20110415-1243).
(In reply to comment #5) > so this isn't actually a bug. Sorry for that. Closing the issue ... > > I would have suspected the newer plug-in to be included in one of the Stream > Integration Builds (i.e. eclipse-e4-repo-incubation-I20110415-1243). If it's not then it sounds like we have a build problem.
Andrew, I don't see a org.eclipse.e4.ui.workbench.addons.swt_0.9.0.v20110414-2200.jar in the eclipse-e4-repo-incubation-I20110415-1243.zip file. Any ideas what might've gone wrong?
org.eclipse.e4.ui.workbench.addons.swt does not seem to be included by any of the e4 features. I guess it should perhaps be added to org.eclipse.e4.ui.feature ?
(In reply to comment #8) > org.eclipse.e4.ui.workbench.addons.swt does not seem to be included by any of > the e4 features. > > I guess it should perhaps be added to org.eclipse.e4.ui.feature ? Actually, we don't include the compatibility layer in this bundle either so including the addons bundle will end up pulling the compatibility layer with it. This could be bad.
So IMHO as always pointed out. I think swt.addons should be splitted into 2 bundles or even better made free from compat features
well splitting into 2 is probably not good as well maybe simply move the classes who can't be freed from compat layer deps simply move the addon there?
(In reply to comment #11) > well splitting into 2 is probably not good as well maybe simply move the > classes who can't be freed from compat layer deps simply move the addon there? I think this is a great idea because then we don't need to introduce additional releng work for Paul and Andrew.
+1, it's just the PerspectiveSwitcher isn't it ? BTW, I think I can change the min/max code to allow both min & max buttons on stacks if there is no 'shared area'...the 'minimize only' code is there to distinguish stacks 'outside' the shared area.
(In reply to comment #11) > well splitting into 2 is probably not good as well maybe simply move the > classes who can't be freed from compat layer deps simply move the addon there? I have released the necessary refactorings to HEAD. (In reply to comment #8) > org.eclipse.e4.ui.workbench.addons.swt does not seem to be included by any of > the e4 features. > > I guess it should perhaps be added to org.eclipse.e4.ui.feature ? Andrew, could you update the build so that the addons bundle gets included in the org.eclipse.e4.ui.feature? Thanks.
Created attachment 193685 [details] Code Changes Following the discussion in Bug 342947 I have checked out the current plug-in from HEAD. I initially got some NullPointerExceptions because I have no "EDITOR_AREA" defined. It seems to me, that (at the moment) it is necessary to define an Element with the ID set ID_EDITOR_AREA. If I modify the code to not use the EDITOR_AREA by check for null, the maximize button will just switch to Restore-Mode without maximizing the PartStack. MinMaxAddon.java - Lines 422 and 445 ModelServiceImpl.java - Line 63 (see Attachment "MinMaxAddon_changes.pdf")
(In reply to comment #15) > Following the discussion in Bug 342947 I have checked out the current plug-in > from HEAD. I initially got some NullPointerExceptions because I have no > "EDITOR_AREA" defined. Hi Christoph, yes, I found some bugs with the min/max support for regular RCP applications yesterday, see bug 343295 (the problem you saw) and bug 343298.
Hi Remy, thanks for the fix! Works like a charm :-) Christoph
(In reply to comment #14) > Andrew, could you update the build so that the addons bundle gets included in > the org.eclipse.e4.ui.feature? Thanks. This is done.
