Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342942 - Bug in PlainDriverDataSource isWrapperFor
Summary: Bug in PlainDriverDataSource isWrapperFor
Status: RESOLVED FIXED
Alias: None
Product: Gemini.JPA
Classification: RT
Component: Core (show other bugs)
Version: 1.0.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.0.0 RC2   Edit
Assignee: Michael Keith CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-15 06:14 EDT by Gunnar Wagenknecht CLA
Modified: 2011-06-02 16:48 EDT (History)
0 users

See Also:
michael.keith: iplog+

Attachments
patch (6.43 KB, patch)
2011-04-15 06:14 EDT, Gunnar Wagenknecht CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gunnar Wagenknecht CLA 2011-04-15 06:14:34 EDT 
Created attachment 193345 [details]
patch

acording to the usage in unwrap isWrapperFor should return true when the class matches, otherwise unwrap would throw a ClassCastException
Comment 1 Gunnar Wagenknecht CLA 2011-04-15 06:15:46 EDT 
Comment on attachment 193345 [details]
patch

The patch also contains a project settings which prevents formatting of the code on save. This file can be skipped, though.
Comment 2 Michael Keith CLA 2011-06-02 16:48:11 EDT 
Thanks for entering. 

Fixed both isWrapperFor() and unwrap() methods to comply with Wrapper interface including correct semantics of the method and throwing SQLException when appropriate.

Released into RC2.