Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342857 - [region] Optimise region digraph for traversal
Summary: [region] Optimise region digraph for traversal
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Components (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Glyn Normington CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-14 11:28 EDT by Glyn Normington CLA
Modified: 2011-04-19 03:40 EDT (History)
1 user (show)

See Also:

Attachments
Remove OrderedPair (8.61 KB, patch)
2011-04-18 13:37 EDT, Thomas Watson CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Glyn Normington CLA 2011-04-14 11:28:18 EDT 
Rather than representing the digraph edges as a map from pairs of regions to the corresponding edge:

    Region x Region +> RegionFilter

map each region to a set of edges:

    Region +> P (Region x Region Filter)

This is more efficient during traversal as the edges not involved in the traversal need not be enumerated.
Comment 1 Thomas Watson CLA 2011-04-18 13:37:52 EDT 
Created attachment 193505 [details]
Remove OrderedPair

Glyn released a change to optimise digraph transversal.  The change removed the need for OrderedPair.  Some of the tests still used it.  This patch removes OrderedPair and modifies the tests to stop using it.

Glyn, please have a look at org.eclipse.virgo.kernel.osgi.region.internal.BundleIdBasedRegionTests.testAddBundle().  The patch removes a couple of lines that did not seem to do anything useful for the test.
Comment 2 Thomas Watson CLA 2011-04-18 15:43:55 EDT 
I went ahead and released my patch to remove OrderedPair.  Closing this as fixed.
Comment 3 Glyn Normington CLA 2011-04-19 03:40:05 EDT 
Thanks Tom. I noticed that OrderedPair was almost dead, but forgot to go back and kill it.