Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 342856 - [Java Discovery] improve Discoverers implementation
Summary: [Java Discovery] improve Discoverers implementation
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Technologies (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.9.0 M7   Edit
Assignee: Fabien Giquel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-14 11:22 EDT by Fabien Giquel CLA
Modified: 2011-08-18 08:11 EDT (History)
3 users (show)

See Also:
fabien.giquel: indigo+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fabien Giquel CLA 2011-04-14 11:22:58 EDT 
Following Discovery framework rewriting, thsi bugs summarizes some implementation problems on 14 "oem.java.*" components.


- Some oem.java.* components should not have any dependency to ui component. e.g. oem.java.discoverer should not have reference to org.eclipse.ui neither to  org.eclipse.gmt.modisco.infra.common.ui.
Using "Find unused dependencies" should help to clean.

- Some Java classes still have a lot of "Discouraged access" warnings. e.g. oem.java.composition should be x-friends for kdm.source.extension.
Comment 1 Nicolas Bros CLA 2011-04-19 11:03:02 EDT 
I removed UI dependencies from these plug-ins:
org.eclipse.modisco.java.discoverer
org.eclipse.modisco.java.discoverer.cdo

But UI dependencies cannot be removed from these plug-ins:
org.eclipse.modisco.java.composition.discoverer
org.eclipse.modisco.java.composition.discoverer.benchmark
org.eclipse.modisco.jee.ejbjar.discoverer
org.eclipse.modisco.jee.jsp.discoverer
org.eclipse.modisco.jee.webapp.discoverer

because they still contain compatibility versions of discoverers, which depend on org.eclipse.gmt.modisco.infra.discoverymanager, which has UI dependencies (org.eclipse.ui, org.eclipse.debug.ui, org.eclipse.ui.ide).
Comment 2 Nicolas Bros CLA 2011-04-19 12:11:21 EDT 
I fixed the warnings in the discovery projects.
Comment 3 Fabien Giquel CLA 2011-04-20 05:35:17 EDT 
You are right about ui dependencies.
There are still jdt undocumented warnings (some coming from old code). I will work on it now.
Comment 4 Fabien Giquel CLA 2011-04-21 05:04:34 EDT 
Fix on warnings have been commited (serveral revisions up to 4344)
No one of the 15 oem.java.* project contains jdt or checkstyle warning anymore.
Comment 5 Hugo Bruneliere CLA 2011-08-18 08:11:21 EDT 
Refactoring done.